search

eclipse-theia / vscode-builtin-extensions

Built-in VS Code extensions for Theia
Other
69 stars 36 forks source link

fix: close #111 #112

Closed yiliang114 closed 1 year ago

yiliang114 commented 1 year ago

Dependencies need to be installed before executing command yarn checkout-latest-vscode-release

yiliang114 commented 1 year ago

Hey @msujew, long time no see 😊

Please take the time to help me see if the effect is in line with expectations.

https://github.com/yiliang114/vscode-builtin-extensions/actions/runs/4489238071/jobs/7894809205

image

msujew commented 1 year ago

Thanks I believe that should do the trick 👍 I'll let @vince-fugnitto do a final review, I'm not too familiar with the builtin extension publishing process.

marcdumais-work commented 1 year ago

Hey @yiliang114 thanks for the contribution.

The prepare script in the package.json will try to bundle the extensions in the vscode folder when running just yarn. This will build incorrect extension versions, since we need to change to a specific vscode tag before we perform the build step. Please move the prepare script into a separate script that is executed after checking out the latest vscode tag.

Good catch Mark. This workflow had not been used in a while, and out of nowhere, started to run again recently. Back when we ran it regularly, I think we did not have a need to install any dependency before calling yarn checkout-latest-vscode-release.

marcdumais-work commented 1 year ago

Note: we disabled publishing the extensions to openvsx in the nightly-run workflows, because we wanted to control when/if this happened. One reason it that it's not possible to easily remove, from openvsx, published extensions, and so if we publish one that does not work correctly, we are stuck with it. Instead, we build and test locally , before proceeding with publishing to open-vsx, by pushing to the ovsx-publish branch. Since we know exactly which version we want to publish, we checkout the vscode submodule to the exact version, when doing so.

This PR is still useful though- we can use the nightly build to confirm that our master branch is able to build the builtins for the latest released vscode.

yiliang114 commented 1 year ago

Sorry, I seem to have made a mistake on request change just now

marcdumais-work commented 1 year ago

@yiliang114 Thank you for updating the PR. There are a few more places in the README where we could update the build command, but this is minor and can be adjusted as part of the next release.