Closed alvsan09 closed 1 year ago
I am testing this one. I think the merge order we want is the following. I also add with which PR we publish which built-ins. WDYT?
Seems to work well! I see that simple-browser
now has index.js
packaged in its .vsix
:
It works!:
What it does
Fixes: https://github.com/eclipse-theia/vscode-builtin-extensions/issues/116
Adding the missing compilation step 'compileExtensionMediaTask' This step (function) is already available in the 'vscode' baseline sub-module.
How to test
1) Using this change and the procedures on this repository
README.md
, buildvsix
files for the latestvscode
sub-module. NOTE: Use the --force option to producevsix
files which are already available in the market place e.g.2) Build
theia
from a repository using the latestmaster
3) Remove the existing version ofvscode.simple-browser
from the thetheia
plugins folder 4) Copy the generated file.../vscode-builtin-extensions/dist/simple-browser-1.70.2.vsix
to yourthiea
repo,plugins
folder The generated file should match the following: simple-browser-1.70.2.zip5) Start
theia
and from the command palette execute the commandSimple Browser: Show
) -> on the input box enter the following site:https://xkcd.com/
4) Verify that the page open as expected.NOTE: This browser may not work for many sites, but that's a separate issue to follow up after the true implementation of this stubbed API.