eclipse-theia / vscode-builtin-extensions

Built-in VS Code extensions for Theia
Other
67 stars 36 forks source link

builtin notebook renderers not built correctly #121

Closed jonah-iden closed 1 year ago

jonah-iden commented 1 year ago

Hi, the builtin notebook renderer extension seems to not being built correctly. There is no published version 1.77.0 like for the other builtin extensions and the compiled files from the renderer-out folder are missing in both exisiting vsix bundles.

jonah-iden commented 1 year ago

@vince-fugnitto could you take a look if you find the time. This is pretty important for the theia builtin notebook support

vince-fugnitto commented 1 year ago

@jonah-iden can you let me know if the following plugin works for you (I'm not sure why it was previously skipped for 1.77.0):

jonah-iden commented 1 year ago

Yeah that seems to work. Thanks for your quick response

vince-fugnitto commented 1 year ago

Yeah that seems to work. Thanks for your quick response

The good thing is the build and packaging seems to work fine (no changes needed). Not sure why it wasn't published however, perhaps it was a decision since we did not have notebook support at the time. Both @marcdumais-work and @alvsan09 are on vacation at this time but I'll post an update when I get in contact with them.

We should also think of publishing 1.78.0 soon since its our latest supported version.

marcdumais-work commented 1 year ago

Hello,

I think there was a glitch when we published the built-ins last, with that extension. Now it's tagged, server-side, and re-trying to publish it consistently fails. We hope that it affects only that specific version, and that when we publish 1.78.0 or 1.79.0, it will just work. In the meantime, I think an older, possibly faulty or non-working version, is picked-up.

We'll discuss internally, about releasing a new set of built-ins, ASAP.

cc: @tsmaeder

vince-fugnitto commented 1 year ago

Note that vscode.builtin-notebook-renderers@1.79.0 has been published successfully.

jonah-iden commented 1 year ago

Nice, Thanks alot. I guess this issue can be closed now