eclipse-theia / vscode-builtin-extensions

Built-in VS Code extensions for Theia
Other
69 stars 36 forks source link

[pack][js-debug] Fix ext pack issue that left-out js-debug* #124

Closed marcdumais-work closed 1 year ago

marcdumais-work commented 1 year ago

Fixes #123

In 1.79.0, the extensions pack we published mistakenly left-out external built-in extensions ms-vscode.js-debug and companion

We use node-fetch to call open-vsx API end-points. For external built-in extensions, we want to make sure they exist on open-vsx before adding them to the pack, to avoid issues when resolving the pack(we do not check for a specific version, because they may not follow vscode's versioning).

It turns-out that For this case, we were generating a URL that had a trailing slash, which did not work

Original URL, returns 404: https://open-vsx.org/api/ms-vscode/js-debug-companion/

Corrected URL (works): https://open-vsx.org/api/ms-vscode/js-debug-companion