Closed rschnekenbu closed 6 days ago
@rschnekenbu is there documentation that needs to be updated with this change?
@tsmaeder, probably some README or how-to-build documentation to update, indeed. I will update this PR
@tsmaeder, I updated the documentation, some commands now relying on npm rather than yarn on vscode repo. This vscode-builtin-extensions repository still uses yarn v1 of course, so many of the building commands and all publishing ones are still yarn based.
I took also the opportunity to update the vscode commit ref to tag 1.94.2 (current latest release on 1.94 stream). I also updated some part of the documentation that had some markdown formatting issues or warnings.
@tsmaeder, as mentionned in my comments I have just added, this repo still relies on yarn. Only vscode submodule and related scripts have been migrated to npm. IMO, this project should still rely on yarn until the main theia repo has migrated to theia. A follow up ticket may be added to update this repo once we have officially switch theia to npm.
@tsmaeder In my opinion this is good to go. I don't think we necessarily need to migrate this repo fully to npm. What do you think?
@rschnekenbu Do you want to squash your changes now? It seems like only "rebase and merge" is enabled for this repo, so I cannot squash the changes for you.
@msujew, do you want to have a last look or are we good to go?
@rschnekenbu Feel free to merge :)
Migrate the package manager of VS Code from yarn to npm Also updates to vscode subrepo to 1.94.2, as this is the first version to rely on npm.
fixes #131
contributed on behalf of STMicroelectronics