bug in markdown syntax when line break included in emphasis

[18kimn]

*this whole sentence
should have italic formatting in vscode*

_this sentence 
should have it too_

**and this sentence should
be bolded**

But currently they show as regular text, and only when the entire string is placed on the same line does the formatting show up.

Here's a commonmark link showing that this works, and two examples in the spec that have this formatting: one two

Github supports it too, so you could try it out on a comment.

Not a huge issue of course, since most parsers seem to support this syntax, but just nice to have editor highlighting for it too :)

[msujew]

@18kimn I'm not too sure that this issue belongs in this repository. We just consume the vscode upstream repo to build and upload the extensions they provide. Perhaps you should file your issue there?

[marcdumais-work]

Nathan, can you tell us which version of the scode.markdown-language-features extension you are using? If not sure, you can look in the "plugins" view.

On Sat, Dec 18, 2021 at 10:52 PM Nathan Kim @.***> wrote:

this whole sentence should have italic formatting in vscode

this sentence should have it too

and this sentence should be bolded

But currently they show as regular text, and only when the entire string is placed on the same line does the formatting show up.

Here's a commonmark https://spec.commonmark.org/dingus/?text=*this%20whole%20sentence%0Ashould%20have%20italic%20formatting%20in%20vscode*%0A%0A_this%20sentence%20%0Ashould%20have%20it%20too_ link showing that this works, and two examples in the spec that have this formatting: one https://spec.commonmark.org/0.30/#example-422 two https://spec.commonmark.org/0.30/#example-493

Github supports it too, so you could try it out on a comment.

Not a huge issue of course, since most parsers seem to support this syntax, but just nice to have editor highlighting for it too :)

— Reply to this email directly, view it on GitHub https://github.com/eclipse-theia/vscode-builtin-extensions/issues/96, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEOMR7JHNJCUMTIK43Q4V3URVJJVANCNFSM5KLNCX2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

[18kimn]

Oh, sounds good @msujew, I'll file an issue there! @marcdumais-work I believe I'm using version 1.0.0

feel free to close this!