eclipse-thingweb / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-thingweb.github.io/.eclipsefdn/
1 stars 3 forks source link

Set number of required approvals for dart_wot to 0 #22

Closed JKRhb closed 6 months ago

JKRhb commented 6 months ago

As discussed in https://github.com/eclipse-thingweb/dart_wot/pull/148, this PR sets the number of required approvals to 0 for the dart_wot repository.

eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization. You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

Otterdog commands and options You can trigger otterdog actions by commenting on this PR: - `/otterdog team-info` checks the team / org membership for the PR author - `/otterdog validate` validates the configuration change - `/otterdog validate info` validates the configuration change, printing also validation infos - `/otterdog check-sync` checks if the base ref is in sync with live settings - `/otterdog merge` merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author) - `/otterdog done` notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team) - `/otterdog apply` re-apply a previously failed attempt (only accessible for members of the admin team)
eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot.

The author (JKRhb) of this PR is associated with this organization in the role of MEMBER.

Additionally, JKRhb is a member of the following teams:

eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for b1c9ba6d69736ef71b72668b17a1b06731ee8a42 ```diff Organization iot.thingweb[id=eclipse-thingweb] ! branch_protection_rule[pattern="main", repository="dart_wot"] { ! required_approving_review_count = "1" -> "0" ! } Plan: 0 to add, 1 to change, 0 to delete. ```
eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 3ca3d9bf965a71594512d17d3b77f335f0000a89 ```diff Organization iot.thingweb[id=eclipse-thingweb] ! branch_protection_rule[pattern="main", repository="dart_wot"] { ! bypass_pull_request_allowances = "['@JKRhb']" -> "[]" ! required_approving_review_count = "1" -> "0" ! } Plan: 0 to add, 2 to change, 0 to delete. ```
eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

netomi commented 6 months ago

LGTM, I removed the bypass actor as this one should not be needed with this change and keep the config cleaner imho.

JKRhb commented 6 months ago

LGTM, I removed the bypass actor as this one should not be needed with this change and keep the config cleaner imho.

Thank you, that makes sense :)

eclipse-otterdog[bot] commented 6 months ago

This is your friendly self-service bot.

The following changes have been successfully applied:


Organization iot.thingweb[id=eclipse-thingweb]

!   branch_protection_rule[pattern="main", repository="dart_wot"] {
!     bypass_pull_request_allowances    = "['@JKRhb']" -> "[]"
!     required_approving_review_count   = "1" -> "0"
!   }

  Applying changes:

  Done.

  Executed plan: 0 added, 2 changed, 0 deleted.
relu91 commented 6 months ago

Thanks! I think we can use this config for dart_wot 👍🏻