search

eclipse-thingweb / playground

Browser application for validating and designing W3C Thing Descriptions and Thing Models.
https://playground.thingweb.io/
Other
28 stars 19 forks source link

Eclipse Foundation Adaptation #457

Closed egekorkan closed 1 year ago

egekorkan commented 1 year ago

As agreed upon in the previous meetings, playground will be submitted to Eclipse Foundation Thingweb Project, next to node-wot.

I have started with the administrative stuff like new markdown files for license, notice etc. I have also moved the prettier and eslint config files from node-wot, changed repository name and bunch of other stuff.

@danielpeintner @relu91 can you have a look to see if it is somewhat ok?

@mkovatsc you are also welcome.

In any case, it is better to review per commit since prettier added a bunch of changes to all the files.

I still need to add the license information to each code file but I hope that there is a simple tooling that allows me to do automate that. If anyone has a pointer, it would be nice. Until then, it is in draft status.

netlify[bot] commented 1 year ago

Deploy Preview for playground-testing failed.

Name Link
Latest commit ede5c37d9feda59f1a1c881f7f6b012dcf562c64
Latest deploy log https://app.netlify.com/sites/playground-testing/deploys/640cb6afe60bb000088f2c85
danielpeintner commented 1 year ago

No real review, just some comments I stumbled over when looking at the draft PR.

  1. I think it would be good to know what you still plan to work on before requesting playground being part of Eclipse thingweb? e.g., I see many warnings w.r.t. the prettier and eslint config files from node-wot. Do you plan to fix them all? What else is missing? I checkbox list might be useful..

  2. I was not super sure whether we ever talked about the actual name. It uses "thingweb.td-playground" and I was asking myself whether we need the "td-" part. The online plugfest URL http://plugfest.thingweb.io/playground/ does not have it either.

I still need to add the license information to each code file but I hope that there is a simple tooling that allows me to do automate that. If anyone has a pointer, it would be nice. Until then, it is in draft status.

I think there are more plugins but https://marketplace.visualstudio.com/items?itemName=angelo-breuer.license-header-manager should do the job I think.

relu91 commented 1 year ago

From what I can tell the configuration files looks good; I don't see any obvious criticality.

fatadel commented 1 year ago

Continued in #464