search

eclipse-thingweb / playground

Browser or Node.js based tool for validating and playing with W3C Thing Descriptions
https://playground.thingweb.io/
Other
28 stars 22 forks source link

TD to AsyncAPI conversion: Incorporating Security Mechanism for TD to AsyncAPI conversion #488

Closed ms-monika closed 11 months ago

ms-monika commented 1 year ago

Addition of the security-related components for converting the TD to AsyncAPI

egekorkan commented 1 year ago

The existing tests are failing and it would be good to adapt the tests to use the security as well.

You should also remove the empty case statement (shown in ESLint Tests)

egekorkan commented 1 year ago

@ms-monika you should change the existing tests as well and make sure to test your code before pushing :)

danielpeintner commented 1 year ago

A general comment that I saw through the diffs of this PR... maybe it makes sense to establish formatting rules for playground. Similar to what we do in node-wot. @egekorkan I let you decide whether that makes sense..

egekorkan commented 12 months ago

A general comment that I saw through the diffs of this PR... maybe it makes sense to establish formatting rules for playground. Similar to what we do in node-wot. @egekorkan I let you decide whether that makes sense..

We actually have that enforced by eslint and prettier where the rules are copied mostly from node-wot: https://github.com/eclipse-thingweb/playground/blob/master/.prettierrc.json (also eslintrc)

egekorkan commented 11 months ago

@ms-monika the tests are failing again sadly. Make sure to test before pushing :)

egekorkan commented 11 months ago

@danielpeintner there are a lot of eslint errors that are still not picked up, even though we had them for a long time. I will fix them in another PR