eclipse-thingweb / playground

Browser or Node.js based tool for validating and playing with W3C Thing Descriptions
https://playground.thingweb.io/
Other
28 stars 22 forks source link

New changes to the example menu #506

Closed SergioCasCeb closed 10 months ago

SergioCasCeb commented 10 months ago

For this pull request, I have:

egekorkan commented 10 months ago

The failing tests can be ignored for now, it is not a problem of this PR. I have tested it locally and it is fine and addresses some of the issues raised by @danielpeintner and @FadySalama about the examples page. A screenshot is below:

image

Something to fix is that the TD TM toggle is not showing the unselected type so it is not clear why one would want to click on it.

netlify[bot] commented 10 months ago

Deploy Preview for playground-new-prreview ready!

Name Link
Latest commit 047535d3d524d339d31fc7c6faa3389b41673a70
Latest deploy log https://app.netlify.com/sites/playground-new-prreview/deploys/6525ab579bd213000823ff85
Deploy Preview https://deploy-preview-506--playground-new-prreview.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan commented 10 months ago

It looks good to me now. Merging