search

eclipse-thingweb / playground

Browser or Node.js based tool for validating and playing with W3C Thing Descriptions
https://playground.thingweb.io/
Other
28 stars 22 forks source link

AAS error handling #514

Closed SergioCasCeb closed 10 months ago

SergioCasCeb commented 10 months ago

Added a similar error handling and message just like the ones utilized for OpenAPI and AsyncAPI.

netlify[bot] commented 10 months ago

Deploy Preview for thingweb-playground ready!

Name Link
Latest commit 073b8d5b9c8d33b89fe8838e8f14538f354a85a8
Latest deploy log https://app.netlify.com/sites/thingweb-playground/deploys/65328ba2ab105d0008ee1414
Deploy Preview https://deploy-preview-514--thingweb-playground.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SergioCasCeb commented 10 months ago

Implemented minor fixes with the new close tab prompt, so that if a user opens an example while the close prompt is open, it will close the prompt.

SergioCasCeb commented 10 months ago

Momentarily removed the "Save as" button until HTTPS is implemented for Playground

danielpeintner commented 10 months ago

What is your opinion @danielpeintner about that? Will node-wot reject an unknown protocol in the future or will it try best effort?

I guess it would be wrong to reject unknown protocols. The current node-wot code does not make any assumption. Hence I agree with your statement "we should accept unknown protocols"

egekorkan commented 10 months ago

. Hence I agree with your statement "we should accept unknown protocols"

But shouldn't we at least give a warning? It feels a bit wrong to be confident about something that doesn't "exist"

danielpeintner commented 10 months ago

But shouldn't we at least give a warning? It feels a bit wrong to be confident about something that doesn't "exist"

I don't feel strongly about it and a warning might be okay. On the other hand, do we warn people in the TD spec about protocols we don't know yet?

egekorkan commented 10 months ago

On the other hand, do we warn people in the TD spec about protocols we don't know yet?

There are plans to add protocol validation and this will indeed be a question. So far "htv:methodName":"GETTER" is accepted

egekorkan commented 10 months ago

@danielpeintner what do you think now? It is only a gray text on the right hand side

danielpeintner commented 10 months ago

@danielpeintner what do you think now? It is only a gray text on the right hand side

Fine by me