search

eclipse-thingweb / playground

Browser or Node.js based tool for validating and playing with W3C Thing Descriptions
http://plugfest.thingweb.io/playground/
Other
28 stars 22 forks source link

Modified quick use button #541

Closed SergioCasCeb closed 6 months ago

SergioCasCeb commented 7 months ago
netlify[bot] commented 7 months ago

Deploy Preview for thingweb-playground ready!

Name Link
Latest commit 686a8f2ada14cf305843c9aff4e698e73f978ee4
Latest deploy log https://app.netlify.com/sites/thingweb-playground/deploys/659e0fbf30081900088af244
Deploy Preview https://deploy-preview-541--thingweb-playground.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan commented 7 months ago

@danielpeintner @mkovatsc do you prefer this more direct "USE" button compared to the icon?

danielpeintner commented 7 months ago

@danielpeintner @mkovatsc do you prefer this more direct "USE" button compared to the icon?

I think it is easier to understand when reading the text without hovering over.

It could even read "LOAD" to me... since I would be unsure what "USE" means... anyhow fine as is.

egekorkan commented 6 months ago

@danielpeintner now we use load as it also makes more sense to me. The failing test is being addressed in another PR.

@SergioCasCeb there should be no changes to the copyright years in this PR. Can you rebase it?

SergioCasCeb commented 6 months ago

@egekorkan what exactly do you mean with the copying years?

Also should the button, when opening the example card, also say load instead of apply to avoid any confusion between the functionality of each button?

egekorkan commented 6 months ago

Also should the button, when opening the example card, also say load instead of apply to avoid any confusion between the functionality of each button?

I hadn't seen that sadly. I think that row with two buttons can either be removed (not sure yet). For now, the "apply" button should also say load.

egekorkan commented 6 months ago

@egekorkan what exactly do you mean with the copying years?

Currently, this PR has 97 file changes but they are due to copyright years (see screenshot below) changing.

image

It even shows the change again (not sure why) since https://github.com/eclipse-thingweb/playground/pull/546 has already did the correction. We are now using the creation date instead of the current year.

SergioCasCeb commented 6 months ago

Ok, I will change the text of the other Button.

And rebase the branch to fix the copyright texts.

SergioCasCeb commented 6 months ago

@egekorkan , I fixed the button name and some styling issues. Still, regarding the copyright issue, I got a bit confused because I checked some other packages in the master branch from the eclipse-thingweb repository and they also have different dates.

By date of creation do you mean the creation of the individual package or the project itself?

Also I don't think rebasing will help me do that, but if you want, with the search function in VSCode I can set everything again to the correct date, or should that be done in another PR on itself?

egekorkan commented 6 months ago

Changing the base branch twice solved the copyright year issues. Merging