eclipse-thingweb / playground

Browser or Node.js based tool for validating and playing with W3C Thing Descriptions
http://plugfest.thingweb.io/playground/
Other
28 stars 22 forks source link

Fixed ESlint issues with the web-new package #570

Closed SergioCasCeb closed 3 months ago

SergioCasCeb commented 3 months ago

Also @egekorkan is there a reason to why we are utilizing such an old version (8 / 2017) of ESlint, or should we bump it up to the 2013 or 2014 versions?

netlify[bot] commented 3 months ago

Deploy Preview for thingweb-playground ready!

Name Link
Latest commit 138cf6070ff1b9764402bfd62a360f96537f9383
Latest deploy log https://app.netlify.com/sites/thingweb-playground/deploys/66036309d621da000801a1e1
Deploy Preview https://deploy-preview-570--thingweb-playground.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan commented 3 months ago

Also @egekorkan is there a reason to why we are utilizing such an old version (8 / 2017) of ESlint, or should we bump it up to the 2013 or 2014 versions?

No reason, probably stayed around and we didn't change it

SergioCasCeb commented 3 months ago

No reason, probably stayed around and we didn't change it

So there is not issue if I bump it up to the latest version right?

Also I still don't fully understand why the web-new test fails in the Default CI & CD Pipeline fails

egekorkan commented 3 months ago

So there is not issue if I bump it up to the latest version right?

Yes, please do so :)

Also I still don't fully understand why the web-new test fails in the Default CI & CD Pipeline fails

The errors are really confusing since it mixes up web and webnew for some reason. Does it work in your machine?