search

eclipse-thingweb / td-tools

Tooling for Thing Descriptions and Thing Models
https://thingweb.io
Other
3 stars 3 forks source link

Add GitHub Action workflows #17

Closed danielpeintner closed 2 weeks ago

danielpeintner commented 2 months ago

Open Questions:

fixes https://github.com/eclipse-thingweb/td-tools/issues/16

egekorkan commented 2 months ago

I will check the tests for async API conversion. For the other questions:

How to deal with eslint and prettier

We have eslint action at https://github.com/eclipse-thingweb/td-tools/blob/main/.github/eslint.yml but we should create one for prettier.

in async-api-converter npm ci does the build also?

The code is javascript so no need for build. We only have a bundling script at https://github.com/eclipse-thingweb/td-tools/blob/main/node/async-api-converter/package.json#L19

Do we want/need Code Coverage as well?

Why not

Do we need the whole test matrix for Windows, MacOS and Ubuntu ?

We should discuss this but given that these tools so far are almost pure javascript code (not much to do with Node.js itself), I would say that we need tests only with Ubuntu.

danielpeintner commented 3 weeks ago

@egekorkan and others I suggest to fix "failing tests for async-api-converter" and look at other aspects maybe also later ...

danielpeintner commented 3 weeks ago

@hasanheroglu improved my draft PR 👍.

I think it is good to be merged. We can still improve in follow-up PRs (code coverage to work might still some internals to be fixed)

hasanheroglu commented 3 weeks ago

@danielpeintner Regarding failing tests for async-api-converter, which ones were failing? Currently all test cases pass in my local.

danielpeintner commented 3 weeks ago

@danielpeintner Regarding failing tests for async-api-converter, which ones were failing? Currently all test cases pass in my local.

Not sure anymore.. maybe it is stable now.. we will see