search

eclipse-thingweb / td-tools

Tooling for Thing Descriptions and Thing Models
https://thingweb.io
Other
3 stars 3 forks source link

add td utils #32

Open hasanheroglu opened 2 days ago

hasanheroglu commented 2 days ago

Closes #18

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (b53a2f1) to head (dbfe1cb). Report is 34 commits behind head on main.

Files Patch % Lines
node/td-utils/src/detectProtocolSchemes.ts 87.80% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32 +/- ## =========================================== + Coverage 74.94% 88.09% +13.14% =========================================== Files 7 2 -5 Lines 986 42 -944 Branches 361 14 -347 =========================================== - Hits 739 37 -702 + Misses 203 5 -198 + Partials 44 0 -44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielpeintner commented 2 days ago

Question: Should we use JS or use TypeScript?

egekorkan commented 2 days ago

Question: Should we use JS or use TypeScript?

All should move to TS soon :) This is an adapted version of the logic in the depths of playground at https://github.com/eclipse-thingweb/playground/blob/master/packages/core/index.js#L1305

danielpeintner commented 2 days ago

Since the code in detectProtocolSchemes.js isn't really complex we could do it right away... Anyway it is fine by me.

hasanheroglu commented 2 days ago

I'm on it now