Closed hasanheroglu closed 4 months ago
Attention: Patch coverage is 95.23810%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 95.23%. Comparing base (
b53a2f1
) to head (7c564d2
). Report is 34 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
node/td-utils/src/detectProtocolSchemes.ts | 95.12% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Question: Should we use JS or use TypeScript?
Question: Should we use JS or use TypeScript?
All should move to TS soon :) This is an adapted version of the logic in the depths of playground at https://github.com/eclipse-thingweb/playground/blob/master/packages/core/index.js#L1305
Since the code in detectProtocolSchemes.js
isn't really complex we could do it right away...
Anyway it is fine by me.
I'm on it now
We had some discussion on this in the regular call:
"protocolSchemes": {
"http":[{
"uri":"http://mylamp.example.com:8080",
"subprotocol":"longpoll"
},
{
"uri":"http://mylamp.example.com:8081"
}]
Closes #18