search

eclipse-thingweb / td-tools

Tooling for Thing Descriptions and Thing Models
https://thingweb.io
Other
3 stars 3 forks source link

Improve linting & prettier settings #8

Open danielpeintner opened 3 months ago

danielpeintner commented 3 months ago

Note: coming from https://github.com/eclipse-thingweb/td-tools/pull/7#issuecomment-1999400383

I noticed some shortcoming w.r.t. to the current setup.

  • in node-wot we used to have eslint-plugin-unused-imports. I think having this might be useful
  • I also noticed that "npm run lint" does not screem if I have unused variables in my code. Useful again I think.
  • I also wonder whether prettier & linting should be based on language level (hence moving it into the /node directory )
egekorkan commented 3 months ago

I also wonder whether prettier & linting should be based on language level (hence moving it into the /node directory )

I agree with this one.

For the other two, I am fine with aligning with node-wot here.