eclipse-thingweb / test-things

Collection of Things that can be used for testing different IoT protocols, security mechanisms and interaction styles
https://thingweb.io
Other
4 stars 2 forks source link

Modbus forms are wrong #23

Closed egekorkan closed 2 months ago

egekorkan commented 9 months ago

The generated Modbus forms contain "href": "?address=1&quantity=1", whereas the address should never be URI Variable. It should be part of the URI modbus+tcp://{address}:{port}/{unitID}/{address}?quantity={?quantity} e.g. modbus+tcp://127.0.0.1:60000/1/1

egekorkan commented 9 months ago

Also, each form has the same address whereas each affordance should have another one.