search

eclipse-thingweb / website

Homepage for Eclipse Thingweb, thingweb.io
https://thingweb.io
4 stars 10 forks source link

move 404 page to content #64

Closed danielpeintner closed 7 months ago

danielpeintner commented 10 months ago

see "Option 2" in https://moonbooth.com/hugo/custom-404/

Note: I cannot properly test it locally ... 404 didn't work before and after this change

netlify[bot] commented 10 months ago

Deploy Preview for thingweb-preview ready!

Name Link
Latest commit 62fdca6877aec4165ff5329a15fb9fdcfebc92c9
Latest deploy log https://app.netlify.com/sites/thingweb-preview/deploys/653b772b40169d0008bd9405
Deploy Preview https://deploy-preview-64--thingweb-preview.netlify.app/404
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

danielpeintner commented 10 months ago

Mhh, it works for simple unknown pages like

https://deploy-preview-64--thingweb-preview.netlify.app/foo

but still fails if it is nested in a folder

https://deploy-preview-64--thingweb-preview.netlify.app/folder/bla

egekorkan commented 10 months ago

It fails but at least it still points to homepage

egekorkan commented 10 months ago

I think we can merge since it is still an improvement. @relu91 ?