eclipse-thingweb / website

Homepage for Eclipse Thingweb, thingweb.io
https://thingweb.io
4 stars 10 forks source link

Aligning Logo Usage #67

Open egekorkan opened 7 months ago

egekorkan commented 7 months ago

This PR:

netlify[bot] commented 7 months ago

Deploy Preview for thingweb-preview ready!

Name Link
Latest commit 16c7ae0452b73bce093cea0ad74895d47d5e6655
Latest deploy log https://app.netlify.com/sites/thingweb-preview/deploys/65ae9d764885bf0008942269
Deploy Preview https://deploy-preview-67--thingweb-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan commented 7 months ago

The preview gets the wrong color scheme preference from my browser. At the same time, given that we do not have a dark scheme for the website, should we only use the light scheme?

egekorkan commented 7 months ago

I am not sure if I would remove logo.png and replace it with some https://raw.githubusercontent.com link to another repository...

Do you have the concern due to performance issues? I would be fine to not remove it since it's a one off case. However it still makes sense since the browser can cache it anyways amd might be even faster (someone who uses GitHub visit the webpage for the first time)

danielpeintner commented 7 months ago

The concern I have is that it is a "website" which gets rendered in the end and I would tend to say the images should be in the same repo. Pointing to other repos etc makes the whole thing rather fragile but maybe it is just me that feels like this..

egekorkan commented 7 months ago

Call on 26.01: