eclipse-thingweb / website

Homepage for Eclipse Thingweb, thingweb.io
https://thingweb.io
4 stars 10 forks source link

Refreshment #7

Closed fatadel closed 4 years ago

fatadel commented 4 years ago

In the first 2 commits, I have fixed typos and grammar mistakes in the narration as well as finished the last paragraph which wasn't complete. In the other 2 commits, I have corrected some instructions, code snippets and also made images up to date so that they reflect the current TD specification.

sebastiankb commented 4 years ago

@egekorkan will review this PR

fatadel commented 4 years ago

@egekorkan Well, regarding most of the comments - I didn't write this article myself. I was just trying to fix typos and some basic grammar mistakes. I can definitely rewrite the whole tutorial the way I would do it, but I don't think that was the task.

egekorkan commented 4 years ago

Thank you for improving this tutorial, it is very valuable for the beginners :)

Could you make sure that:

Additional feedback:

egekorkan commented 4 years ago

@egekorkan Well, regarding most of the comments - I didn't write this article myself. I was just trying to fix typos and some basic grammar mistakes. I can definitely rewrite the whole tutorial the way I would do it, but I don't think that was the task.

I think that with my comment above, you will see that there are more typos to be corrected. Otherwise, for things that are not typos, I leave the decision to @sebastiankb .

sebastiankb commented 4 years ago

I think there is no need to rewrite this tutorial. The intention was to update the content regarding the latest TD version and make sure that the commands are still valid with the latest node-wot version.

sebastiankb commented 4 years ago

A typo fix and some clarification of the spelling, as mentioned above in @egekorkan comment, would also be useful if we are refreshing the tutorial anyway.

fatadel commented 4 years ago

@sebastiankb I did the fixes and spelling clarifications without any rewriting, so it's now again ready for review (@egekorkan). From my side, there are some open questions left:

  1. Do I need to create faster and more accurate gif videos?
  2. Shall we change the part which talks about supported/recommended Node.js versions (imho outdated now)?
  3. There is a description for the wpa_supplicant.conf file but no any info for ssh, although they both are said to create. Shall we add that as well?
  4. More meaningful page title? Now it's just "thingweb - ".

I think that's it. I'll add more if I come up with any.

sebastiankb commented 4 years ago

Many thanks @fatadel. I thinks, your 4 points are valid and should be discussed in a new PR. I'm going to merge this PR to have now new updated version so far.