Closed fatadel closed 4 years ago
@egekorkan will review this PR
@egekorkan Well, regarding most of the comments - I didn't write this article myself. I was just trying to fix typos and some basic grammar mistakes. I can definitely rewrite the whole tutorial the way I would do it, but I don't think that was the task.
Thank you for improving this tutorial, it is very valuable for the beginners :)
Could you make sure that:
Additional feedback:
https://github.com/w3c/wot
as a reference since it is just a data dump. Give either the main page or IG page for further referencesStandard description
really weird. Should the reader understand that is where the standard is or where you would a a standard/basic TD@egekorkan Well, regarding most of the comments - I didn't write this article myself. I was just trying to fix typos and some basic grammar mistakes. I can definitely rewrite the whole tutorial the way I would do it, but I don't think that was the task.
I think that with my comment above, you will see that there are more typos to be corrected. Otherwise, for things that are not typos, I leave the decision to @sebastiankb .
I think there is no need to rewrite this tutorial. The intention was to update the content regarding the latest TD version and make sure that the commands are still valid with the latest node-wot version.
A typo fix and some clarification of the spelling, as mentioned above in @egekorkan comment, would also be useful if we are refreshing the tutorial anyway.
@sebastiankb I did the fixes and spelling clarifications without any rewriting, so it's now again ready for review (@egekorkan). From my side, there are some open questions left:
wpa_supplicant.conf
file but no any info for ssh
, although they both are said to create. Shall we add that as well?I think that's it. I'll add more if I come up with any.
Many thanks @fatadel. I thinks, your 4 points are valid and should be discussed in a new PR. I'm going to merge this PR to have now new updated version so far.
In the first 2 commits, I have fixed typos and grammar mistakes in the narration as well as finished the last paragraph which wasn't complete. In the other 2 commits, I have corrected some instructions, code snippets and also made images up to date so that they reflect the current TD specification.