eclipse-thingweb / website

Homepage for Eclipse Thingweb, thingweb.io
https://thingweb.io
4 stars 10 forks source link

Implementing Google Analytics #74

Closed SergioCasCeb closed 4 months ago

SergioCasCeb commented 5 months ago

This is a new implementation of Google Analytics as well as the required consent banner to handle the necessary Google tags and therefore comply with any Eclipse Google Analytics Policy.

netlify[bot] commented 5 months ago

Deploy Preview for thingweb-preview ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/thingweb-preview/deploys/662258a9b03528c7b34b88bd
Deploy Preview https://deploy-preview-74--thingweb-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

danielpeintner commented 5 months ago

FYI: I just noticed that the header image lays over the consent banner. I think it should be the other way around...

image

SergioCasCeb commented 5 months ago

FYI: I just noticed that the header image lays over the consent banner. I think it should be the other way around...

image

Interesting, I didn't notice that while testing. But most likely because my viewport is too big for the banner to even reach the header. I will fix it. Thank you 😁

SergioCasCeb commented 5 months ago

That should do the trick, nonetheless. If the plan is to stick to Hugo, I believe it would be really necessary to refactor the project, not just in regards to utilizing the newest version of Hugo but also revising how the styling is being handled.

egekorkan commented 5 months ago

The PR looks good. It is not going to the main branch anyways but to my existing PR. If some give the OK, I will merge it and then trigger Eclipse Webmaster on the other PR.

SergioCasCeb commented 5 months ago

Google Analytics and Consent Process

Screenshot 2024-04-16 215204 Screenshot 2024-04-16 215233

Screenshot 2024-04-16 221546 Screenshot 2024-04-16 221623

Screenshot 2024-04-16 233108 Screenshot 2024-04-16 233127

danielpeintner commented 5 months ago

The PR seems fine to me as well 👍.

Once the consent banner is hidden it might be difficult for users to find the "Manage Cookies" link in the footer. Anyhow, I don't have a good alternative other than creating a dedicated cookie button in the bottom right corner or so... not sure if this might work better.

An example what I mean can be seen on https://www.cookieyes.com/documentation/change-cookie-consent-using-cookieyes/

SergioCasCeb commented 5 months ago

The PR seems fine to me as well 👍.

Once the consent banner is hidden it might be difficult for users to find the "Manage Cookies" link in the footer. Anyhow, I don't have a good alternative other than creating a dedicated cookie button in the bottom right corner or so... not sure if this might work better.

An example what I mean can be seen on https://www.cookieyes.com/documentation/change-cookie-consent-using-cookieyes/

That could be a nice, simple solution. For the moment we could also specify on the banner that the user preferences can always be changed/updated on the link below.

egekorkan commented 5 months ago

For the moment we could also specify on the banner that the user preferences can always be changed/updated on the link below.

This would be actually good. Could you add it to the PR?

danielpeintner commented 4 months ago

BTW, the name of the PR "Implementing Google Analytics" does not convey the actual content. I think it should rather say "Implementing Consent Banner"

egekorkan commented 4 months ago

We checked in the commiter's call and after those two small changes, we can merge and ping Webmaster

danielpeintner commented 4 months ago

@egekorkan the PR goes againts eclipse-thingweb:egekorkan-patch-2

egekorkan commented 4 months ago

@egekorkan the PR goes againts eclipse-thingweb:egekorkan-patch-2

Yes this is just updating the PR I already had. That PR is linked in the Eclipse helpdesk