Closed SergioCasCeb closed 4 months ago
Name | Link |
---|---|
Latest commit | |
Latest deploy log | https://app.netlify.com/sites/thingweb-preview/deploys/662258a9b03528c7b34b88bd |
Deploy Preview | https://deploy-preview-74--thingweb-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
FYI: I just noticed that the header image lays over the consent banner. I think it should be the other way around...
FYI: I just noticed that the header image lays over the consent banner. I think it should be the other way around...
Interesting, I didn't notice that while testing. But most likely because my viewport is too big for the banner to even reach the header. I will fix it. Thank you 😁
That should do the trick, nonetheless. If the plan is to stick to Hugo, I believe it would be really necessary to refactor the project, not just in regards to utilizing the newest version of Hugo but also revising how the styling is being handled.
The PR looks good. It is not going to the main branch anyways but to my existing PR. If some give the OK, I will merge it and then trigger Eclipse Webmaster on the other PR.
Google Analytics and Consent Process
analytics_storage
, and the user's preference is saved to be used as the new default state.
The PR seems fine to me as well 👍.
Once the consent banner is hidden it might be difficult for users to find the "Manage Cookies" link in the footer. Anyhow, I don't have a good alternative other than creating a dedicated cookie button in the bottom right corner or so... not sure if this might work better.
An example what I mean can be seen on https://www.cookieyes.com/documentation/change-cookie-consent-using-cookieyes/
The PR seems fine to me as well 👍.
Once the consent banner is hidden it might be difficult for users to find the "Manage Cookies" link in the footer. Anyhow, I don't have a good alternative other than creating a dedicated cookie button in the bottom right corner or so... not sure if this might work better.
An example what I mean can be seen on https://www.cookieyes.com/documentation/change-cookie-consent-using-cookieyes/
That could be a nice, simple solution. For the moment we could also specify on the banner that the user preferences can always be changed/updated on the link below.
For the moment we could also specify on the banner that the user preferences can always be changed/updated on the link below.
This would be actually good. Could you add it to the PR?
BTW, the name of the PR "Implementing Google Analytics" does not convey the actual content. I think it should rather say "Implementing Consent Banner"
We checked in the commiter's call and after those two small changes, we can merge and ping Webmaster
@egekorkan the PR goes againts eclipse-thingweb:egekorkan-patch-2
@egekorkan the PR goes againts eclipse-thingweb:egekorkan-patch-2
Yes this is just updating the PR I already had. That PR is linked in the Eclipse helpdesk
This is a new implementation of Google Analytics as well as the required consent banner to handle the necessary Google tags and therefore comply with any Eclipse Google Analytics Policy.