search

eclipse-threadx / netxduo

Eclipse ThreadX - NetXDuo is an advanced, industrial-grade TCP/IP network stack designed specifically for deeply embedded real-time and IoT applications
https://github.com/eclipse-threadx/rtos-docs/blob/main/rtos-docs/netx-duo/index.md
MIT License
230 stars 131 forks source link

test: add test comments to header file #91

Closed hakehuang closed 2 years ago

hakehuang commented 2 years ago

for iperf we may need customerize the ports in test farm.

so add an test Anchor commnets here for each replacement

Signed-off-by: Hake Huang hake.huang@oss.nxp.com

TiejunMS commented 2 years ago

Hi @hakehuang, are you able to redefine NX_IPERF_TCP_RX_PORT and NX_IPERF_UDP_RX_PORT in project settings for testing purpose?

hakehuang commented 2 years ago

Hi @hakehuang, are you able to redefine NX_IPERF_TCP_RX_PORT and NX_IPERF_UDP_RX_PORT in project settings for testing purpose?

yes, we can. But modify project is not good for porting, as we plan to port this application to different IDE, set the marco in line maybe more portable friendly.

TiejunMS commented 2 years ago

Hi @hakehuang, are you able to redefine NX_IPERF_TCP_RX_PORT and NX_IPERF_UDP_RX_PORT in project settings for testing purpose?

yes, we can. But modify project is not good for porting, as we plan to port this application to different IDE, set the marco in line maybe more portable friendly.

How about adding those definitions in nx_user.h as per https://docs.microsoft.com/en-us/azure/rtos/netx-duo/chapter2#configuration-options?

hakehuang commented 2 years ago

How about adding those definitions in nx_user.h as per https://docs.microsoft.com/en-us/azure/rtos/netx-duo/chapter2#configuration-options?

@TiejunMS, as these configuration is not netx stack related, it is pure iperf related, so I would prefer to keep the code as is.

hakehuang commented 2 years ago

@TiejunMS any more comments on this PR. Thanks in advance.