search

eclipse-threadx / threadx

Eclipse ThreadX is an advanced real-time operating system (RTOS) designed specifically for deeply embedded applications.
https://github.com/eclipse-threadx/rtos-docs/blob/main/rtos-docs/threadx/index.md
MIT License
2.87k stars 782 forks source link

Missing a parentheses? #215

Closed mikisama closed 1 year ago

mikisama commented 1 year ago

Hi,

The comments in the assembly code seem to be missing a parentheses. Not only the risc-v32 iar port.

diff --git a/ports/risc-v32/iar/src/tx_thread_context_restore.s b/ports/risc-v32/iar/src/tx_thread_context_restore.s
index 8a23b6e..3d497f2 100644
--- a/ports/risc-v32/iar/src/tx_thread_context_restore.s
+++ b/ports/risc-v32/iar/src/tx_thread_context_restore.s
@@ -180,7 +180,7 @@ _tx_thread_context_restore:
     /* }  */
 _tx_thread_not_nested_restore:
     /* Determine if a thread was interrupted and no preemption is required.  */
-    /* else if (((_tx_thread_current_ptr) && (_tx_thread_current_ptr == _tx_thread_execute_ptr) 
+    /* else if (((_tx_thread_current_ptr) && (_tx_thread_current_ptr == _tx_thread_execute_ptr))
                || (_tx_thread_preempt_disable))

image

goldscott commented 1 year ago

Hi @mikisama - thanks for finding this! I'll close this ticket once we have a release that fixes these comments.

TiejunMS commented 1 year ago

Fixed in 6.2.1 release. Closing.