Theme that replicates the coloring of the WTP XML editor

[kevloral]

Having a theme that replicated the coloring scheme used in the WTP XML editor would be nice.

[angelozerr]

Any contribution are welcome!

[kevloral]

The theme is called "Traditional" and it is quite close to the syntax coloring scheme used in the WTP XML editor. It is not perfect, though, as some elements that would colored differently in the original editor share the same CSS here. For the time being, the only difference I have been able to find can be seen on this screenshot, but there could be more:

In the original WTP editor, the equals sign would be black, but here that sign shares the same CSS (.meta.tag) as the tag delimiters.

[angelozerr]

The theme is called "Traditional" and it is quite close to the syntax coloring scheme used in the WTP XML editor.

You say that it is Traditional because you think about WTP. But this theme is not "Traditional" for Java code color. It is Tradionnal for WTP but not for other editor. It is the reason why I suggested to rename to WTP.

@sebthom what do you think about that?

It is not perfect

It is a good start! Thanks so much for your contribution.

[sebthom]

If the theme is specific for XML files, maybe it should be added to the language pack instead of the default UI plugin and be named "WTP XML Classic" or something like this?

[kevloral]

You are both right. I named it Traditional because, as you may imagine, I have started using this XML editor after having used the WTP XML editor for years. Therefore, I agree something along the lines of "WTP XML Classic" would be much more appropriate.

[angelozerr]

If the theme is specific for XML files,

It is specific for WTP, in other words CSS, XML, HTML.

Therefore, I agree something along the lines of "WTP XML Classic" would be much more appropriate.

+1

maybe it should be added to the language pack

I have not strong opinion about that

[sebthom]

We could also just call the theme WTP or Eclipse WTP if it was used by WTP for more than just XML files.

[kevloral]

Please note that I have only tested the new theme with XML files.

[sebthom]

@kevloral you seemed to have closed your PR. Is this enhancement not needed anymore?

[kevloral]

My bad. I thought it had already been merged. I have a local copy of the .css file, so I will use it to create a new PR for this.