search

eclipse-tm4e / tm4e

TextMate support in Eclipse IDE
https://projects.eclipse.org/projects/technology.tm4e
Eclipse Public License 2.0
93 stars 56 forks source link

feat: Add deployment repository #772

Closed GliczDev closed 3 months ago

GliczDev commented 3 months ago

What does this PR do?

Adds deployment repository

The only problem is that I'm not sure how should I configure Jenkinsfile for deployment https://github.com/eclipse/tm4e/blob/d77316439d39a8254a455f207dbb4c582968a9e2/Jenkinsfile#L28 should I add deploy goal here?

sebthom commented 3 months ago

Thanks for your PR. For being able to process this PR, you need to sign the Eclipse Contributor Agreement (ECA)

sebthom commented 3 months ago

What does this PR do?

Adds deployment repository

The only problem is that I'm not sure how should I configure Jenkinsfile for deployment

https://github.com/eclipse/tm4e/blob/d77316439d39a8254a455f207dbb4c582968a9e2/Jenkinsfile#L28

should I add deploy goal here?

no, this job is only for snapshot builds.

Release builds are done by https://ci.eclipse.org/tm4e/job/promote-snapshot-to-release/ but I don't know what/how to change it so it deploys to maven central.

GliczDev commented 3 months ago

Thanks for your PR. For being able to process this PR, you need to sign the Eclipse Contributor Agreement (ECA)

done

deploys to maven central.

wdym maven central? my PR adds repo.eclipse.org tm4e deployment repository.

Release builds are done by https://ci.eclipse.org/tm4e/job/promote-snapshot-to-release/ but I don't know what/how to change it so it deploys to maven central.

I think adding mvn deploy should be enough, but I don't use maven so I'm not sure.

sebthom commented 3 months ago

I think adding mvn deploy should be enough, but I don't use maven so I'm not sure.

adding deploy here will still only publish to the snapshot repo as this Jenkins job is not used to create releases. also it would unnecessarily publish all modules to the snapshot repo, not only the core module. I am going to prepare a separate PR that only publishes the core module.

sebthom commented 3 months ago

Thanks for the PR!