search

eclipse-tm4e / tm4e

TextMate support in Eclipse IDE
https://projects.eclipse.org/projects/technology.tm4e
Eclipse Public License 2.0
93 stars 56 forks source link

Fortran support #806

Closed jmozmoz closed 1 week ago

jmozmoz commented 1 month ago

Eclipse "terminated" the PTP (Parallel Tools Platform) project, including the support for Fortran (https://www.eclipse.org/projects/tools/reviews.php, search for November 29, 2023, Eclipse Parallel Tools Platform Eclipse Parallel Tools Platform (PTP) Termination, the link itself seems to not exist any more).

There is a project to support Fortran in VS Code: https://github.com/fortran-lang/vscode-fortran-support

Just an idea: Could support for Fortran also be added to TM4e based on that project?

mickaelistria commented 1 month ago

A PR adding to TM4E a TextMate grammar to get fortran syntax highlighting would be very welcome. Would you like to submit one? Note that only syntax highlighting would be present. If you want further assistance, you'd most likely also need to bind Fortran files to fortls. In some cases, this can be tried just by configuration in the IDE (as documented in https://github.com/eclipse/lsp4e/blob/main/documentation/using-language-server-via-configuration-no-code.md ), but for more complex or advanced case, it requires writing some Eclipse plugin. If you're interested in this, please get in touch with LSP4E project support channels for assistance in setting up such a project.

angelozerr commented 1 month ago

Adding TextMate and too language configuration https://github.com/fortran-lang/vscode-fortran-support/blob/main/language-configuration.json to benefit from auto close, etc

sebthom commented 1 month ago

I'm not in favor of adding more languages from other sources to the TM4E language pack due to the required Eclipse IP review process for each and every update. Occasionally updating all languages from https://github.com/microsoft/vscode/tree/main/extensions in one go is fine, but having to do the same for more languages from other sources is cumbersome.

Btw. I added Fortran syntax highlighting to https://marketplace.eclipse.org/content/extra-syntax-highlighting-plugin where upstream updates are automatically included and are immediately available.

jmozmoz commented 1 month ago

I'm not in favor of adding more languages from other sources to the TM4E language pack due to the required Eclipse IP review process for each and every update. Occasionally updating all languages from https://github.com/microsoft/vscode/tree/main/extensions in one go is fine, but having to do the same for more languages from other sources is cumbersome.

Btw. I added Fortran syntax highlighting to https://marketplace.eclipse.org/content/extra-syntax-highlighting-plugin where upstream updates are automatically included and are immediately available.

Thank you very much for this. Actually, I looked first to the extra-syntax-highlighting-plugin, didn't find Fortran there and thought, it first has to be added to TM4E. So this actually solves my "problem".

As I obviously do not understand the relations between the different projects/plugins: Is there an explanation, what needs to be added where to support a new language? Also what is needed to for different levels of support like syntax highlighting, code generation, ...

sebthom commented 1 month ago

TM4E provides the ability to perform syntax highlighting using textmate grammars. It comes with a language pack that contains all textmate grammars that are copied from the vscode source repo. so it supports highlighting the same languages out of the box as vscode. tm4e provides an extension point that allows other plugins such as the extra-syntax-highlighting-eclipse-plugin to install additional textmate grammars for other languages. so they extra-syntax-highlighting-eclipse-plugin requires tm4e which does the actual syntax highlighting.

if you want more than just syntax highlighting such as auto completion, refactoring, code generation, syntax validation,... an additional plugin needs to providea language server that is registered with the lsp4e plugin. such a plugin would for example be the wildwebdeveloper plugin offering typescript language support.

sebthom commented 1 week ago

I am going to close the issue as not planned for now. Main hurdle for me is the IP review process for each update requiring a separatly filled out issue and which takes several weeks for approval. The extra-syntax-highlighting-eclipse-plugin is not bound to this process and can be updated timely and with way less effort.