search

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0
4 stars 14 forks source link

Remove incubator flamechart views from trace server #12

Open bhufmann opened 6 months ago

bhufmann commented 6 months ago

With the migration of the incubator flame chart and related views as well as their implementation to mainline Trace Compass https://github.com/eclipse-tracecompass/org.eclipse.tracecompass/pull/9 the trace server will now show 3 different flame chart views (classic, incubator and new) in the available views. As a first step the incubator flamechart plug-in should be removed from the trace server.

Removing the flamechart plug-in will require other incubator plug-ins to remove their dependencies to the incubator flamechart plug-in and use the mainline implementation instead.

Plug-ins to remove from traceserver.product

Plug-ins to update (used in trace server)

Note: The source code migrated to the mainline Trace Compass should be removed from the incubator repository.

Plug-ins to update after removing the code

MatthewKhouzam commented 6 months ago

@arfio Thoughts?

arfio commented 6 months ago

I agree that this should be done after the following pull request is merged: https://github.com/eclipse-tracecompass/org.eclipse.tracecompass/pull/23 Aside from that:

bhufmann commented 6 months ago

I noticed that org.eclipse.tracecompass.incubator.callstack.core.sampled.callgraph package hasn't been migrated to mainline. This needs to be done before removing the incubator plug-in.

arfio commented 6 months ago

The org.eclipse.tracecompass.incubator.callstack.core.sampled.callgraph package was added to this PR: https://github.com/eclipse-tracecompass/org.eclipse.tracecompass/pull/23