search

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0
2 stars 11 forks source link

Remove references to the incubator callstack #18

Closed arfio closed 3 months ago

arfio commented 3 months ago

This PR is intended to resolve the issue https://github.com/eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator/issues/12

Some classes were not moved to profiling.core so this patch is dependent on https://github.com/eclipse-tracecompass/org.eclipse.tracecompass/pull/51

This fixes the following projects:

[Fixes] remove incubator callstack dependencies

bhufmann commented 3 months ago

Trace Compass baseline build is available and this PR doesn't have any compilation errors anymore. However, there are some test errors which need to be addressed as well:

https://github.com/eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator/actions/runs/8559375092/job/23678280523?pr=18#step:5:14103

arfio commented 3 months ago

The ROCm plugin will be updated separately, the incubator callstack and the ROCm plugin were removed from the trace server. The incubator analysis was kept because the trace event plugin is dependent on the aspects. The tests errors were corrected.

arfio commented 3 months ago

Good catch, I agree with you. Do you think the xml analysis should be added to org.eclipse.tracecompass.analysis.profiling.core or org.eclipse.tracecompass.tmf.analysis.xml.core ? I personally think xml would be better.

bhufmann commented 3 months ago

Good catch, I agree with you. Do you think the xml analysis should be added to org.eclipse.tracecompass.analysis.profiling.core or org.eclipse.tracecompass.tmf.analysis.xml.core ? I personally think xml would be better.

I think it should be part of org.eclipse.tracecompass.tmf.analysis.xml.core with the rest of the xml analysis code.