search

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0
2 stars 11 forks source link

uftrace: add support for UTC offset information #26

Closed MatthewKhouzam closed 2 months ago

MatthewKhouzam commented 2 months ago

This is a soon to be released feature in uftrace, allows correlation with lttng kernel traces.

This fixes all traces being from boot time and helps with correlation. image

Fixes https://github.com/namhyung/uftrace/pull/1923

honggyukim commented 2 months ago

Hi @MatthewKhouzam, https://github.com/namhyung/uftrace/pull/1923 is now on master so you can use it.

honggyukim commented 2 months ago

I didn't read the code carefully but please make sure to handle backward compatibiliy since the previous uftrace data doesn't have utc_offset field in its info.

bhufmann commented 2 months ago

Incubator build is still broken. It needs the PR #28 to be merged first and then a rebase.

MatthewKhouzam commented 2 months ago

I didn't read the code carefully but please make sure to handle backward compatibiliy since the previous uftrace data doesn't have utc_offset field in its info.

I should have replied earlier.

It assumes UTC Offset is 0. If there is a field named UTC Offset and it is NOT "0" it tries to parse the number. If it succeeds in parsing, it assigns the offset to the non-zero value.

MatthewKhouzam commented 2 months ago

Simple rebase

honggyukim commented 2 months ago

I didn't read the code carefully but please make sure to handle backward compatibiliy since the previous uftrace data doesn't have utc_offset field in its info.

I should have replied earlier.

It assumes UTC Offset is 0. If there is a field named UTC Offset and it is NOT "0" it tries to parse the number. If it succeeds in parsing, it assigns the offset to the non-zero value.

Sounds good. Thanks your work!