search

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0
2 stars 11 forks source link

Fix compilation error after Trace Compass API clean-up #28

Closed bhufmann closed 2 months ago

bhufmann commented 2 months ago

See https://github.com/eclipse-tracecompass/org.eclipse.tracecompass/issues/87 for API clean-up.

Note: XAF was broken before due incompatible changes in mainline TC. This PR just makes it compile again, but it's still broken.

Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com

arfio commented 2 months ago

I think we should make sure that it is using the same set of classes and not a mix of the old and new ones that will create issues later (at least in the same file).

bhufmann commented 2 months ago

I think we should make sure that it is using the same set of classes and not a mix of the old and new ones that will create issues later (at least in the same file).

@MatthewKhouzam could you please confirm that you can address that in your follow-up PR?

MatthewKhouzam commented 2 months ago

I will share the WIP soon. This is being done on a "volunteer" basis though. We need to get the build going soon.