ftrace: improve binary parser speed by optimizing I/O

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0

2 stars 11 forks source link

ftrace: improve binary parser speed by optimizing I/O #31

Closed fabrizioiannetti closed 1 month ago

fabrizioiannetti commented 1 month ago

mmap the whole file for faster parsing
re-use the same mapping to read events

on my (oldish) laptop with ubuntu 24.04 the file is parsed an order of magnitude faster

on a recent windows laptop I measured two orders of magnitude faster

MatthewKhouzam commented 1 month ago

This is still WIP. I know your approach will work, we didn't have time to get it done. (We start by coding defensively, then optimize) This will be great, please remove the printlns though ;)

fabrizioiannetti commented 1 month ago

This is still WIP. I know your approach will work, we didn't have time to get it done. (We start by coding defensively, then optimize) This will be great, please remove the printlns though ;)

missed that one :-), removed the println.

fabrizioiannetti commented 1 month ago

Hi, is something missing in the PR for review?

MatthewKhouzam commented 1 month ago

@fabrizioiannetti thank you so much for the contribution!