search

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0
4 stars 14 forks source link

Implement Execution Comparison #38

Closed vladarama closed 2 months ago

vladarama commented 3 months ago

This PR is a cleanup based on @farajidaneshgar work on the execution comparison (Original PR). The cleanup includes fixing Eclipse and SonarLint warnings and includes some general code quality and formatting improvements.

Signed-off-by: Vlad Arama vlad.arama@ericsson.com

vladarama commented 3 months ago

@arfio Thanks for the review, I finished addressing your comments. I left some questions in the Conversation tabs. I would appreciate a second review when you have the time.

vladarama commented 2 months ago

@arfio Thanks for the review. I squashed my commits, can you reapprove the changes when you get the chance ?

bhufmann commented 2 months ago

@bhufmann @arfio I think we can merge this patch as is and do separate follow-up patches for the RCP, update site and documentation which would be easier to review than keeping everything in the same patch.

Make sense. I'm ok with this. Please include the plugins and feature to the analysis/pom.xml. If it builds successfully, then we can merged.