server: fix NPE when fetch a trace by UUID and it's not available

eclipse-tracecompass-incubator / org.eclipse.tracecompass.incubator

Eclipse Public License 2.0

5 stars 14 forks source link

server: fix NPE when fetch a trace by UUID and it's not available #89

Closed bhufmann closed 1 month ago

bhufmann commented 2 months ago

Fixes regression introduced by pull request: https://github.com/eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator/pull/79

[Fixed] NPE when fetch a trace by UUID and it's not available

Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com

bhufmann commented 1 month ago

I noticed this because of failing test in the tsp-python-client CI, after troubleshooting, I noticed this PR was fixing this issue, and applying the patch fixed it. This looks perfect and adds regression tests, thank you !

Thanks for the review. Yes, it fixes the issue. But, we found another related issue (i.e. unnecessary instantiating of trace resources) which is addressed with #90/#91. This PR will be obsolete after #90/#91 are merged.

bhufmann commented 1 month ago

Fixed with #90.