search

eclipse-tracecompass / org.eclipse.tracecompass

Eclipse Trace Compass
https://eclipse.dev/tracecompass/
Eclipse Public License 2.0
13 stars 13 forks source link

TIDs do not resolve for lttng ust events in traces with kernel traces. #77

Open MatthewKhouzam opened 5 months ago

MatthewKhouzam commented 5 months ago

When a kernel and userspace trace are in an experiement, the userspace trace should have the TID resolved to the kernel's one as the information is present.

image

This is causing the new callstack to not resolve tids and not work as well as the incubator callstack. The missing analyes are in the incubator analysis core section:

@Override
protected void startActions() {
    TmfTraceUtils.registerEventAspect(AnalysisTidAspect.getInstance());
    TmfTraceUtils.registerEventAspect(AnalysisProcessNameAspect.getInstance());
    TmfTraceUtils.registerEventAspect(AnalysisThreadNameAspect.getInstance());
    TmfTraceUtils.registerEventAspect(AnalysisPidAspect.getInstance());
}

Here is a trace to test the results.

xz-52.zip

Blocks #76

MatthewKhouzam commented 5 months ago

It looks like replacing all trace.getEventAspects() with TmfTraceUtils.getEventAspects(trace,...) fixes it.