eclipse-tractusx / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-tractusx.github.io/.eclipsefdn/
1 stars 15 forks source link

feat: new repository puris #10

Closed mhellmeier closed 1 year ago

mhellmeier commented 1 year ago

Description

As discussed in the Eclipse help desk ticket 3385, we would like to merge the puris-frontend and puris-backend repository into a new puris repository.

This pull requests updates the otterdog configuration to add the new repo.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-actions[bot] commented 1 year ago
Diff for 5af81bc874de6f019063729dd60c70b31faf435d: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 49 validation infos, enable verbose output with '-v' to to display them. + add repository[name="puris"] { + allow_auto_merge = False + allow_forking = True + allow_merge_commit = True + allow_rebase_merge = True + allow_squash_merge = True + allow_update_branch = False + archived = False + default_branch = "main" + delete_branch_on_merge = False + dependabot_alerts_enabled = True + description = "puris" + has_issues = True + has_projects = True + has_wiki = True + homepage = None + is_template = False + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "puris" + private = False + secret_scanning = "enabled" + secret_scanning_push_protection = "disabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = None + topics = [] + web_commit_signoff_required = False } Plan: 1 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -443,7 +443,6 @@ web_commit_signoff_required: false, }, orgs.newRepo('sig-project-management') { - aliases: ['sig-project-managment'], allow_update_branch: false, secret_scanning_push_protection: "disabled", web_commit_signoff_required: false, ```
mhellmeier commented 1 year ago

@Siegfriedk : Can you review, please?

CC: @AngelikaWittek

github-actions[bot] commented 1 year ago
Diff for b9acee7055e6bc5bd0e80d93b0e1d4461dae23ed: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 50 validation infos, enable verbose output with '-v' to to display them. + add repository[name="puris"] { + allow_auto_merge = False + allow_forking = True + allow_merge_commit = True + allow_rebase_merge = True + allow_squash_merge = True + allow_update_branch = False + archived = False + default_branch = "main" + delete_branch_on_merge = True + dependabot_alerts_enabled = True + description = "Predictive Unit Real-Time Information Service (PURIS) for Short Term Demand and Capacity Management" + has_issues = True + has_projects = True + has_wiki = True + homepage = None + is_template = False + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "puris" + private = False + secret_scanning = "enabled" + secret_scanning_push_protection = "disabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = None + topics = [] + web_commit_signoff_required = False } + add branch_protection_rule[pattern="main", repository="puris"] { + allows_deletions = False + allows_force_pushes = False + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = False + is_admin_enforced = False + lock_allows_fetch_and_merge = False + lock_branch = False + pattern = "main" + push_restrictions = [] + require_last_push_approval = False + required_approving_review_count = "1" + requires_approving_reviews = True + requires_code_owner_reviews = False + requires_commit_signatures = False + requires_conversation_resolution = False + requires_deployments = False + requires_linear_history = False + requires_status_checks = False + restricts_review_dismissals = False } Plan: 2 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -451,7 +451,6 @@ web_commit_signoff_required: false, }, orgs.newRepo('sig-project-management') { - aliases: ['sig-project-managment'], allow_update_branch: false, secret_scanning_push_protection: "disabled", web_commit_signoff_required: false, ```
github-actions[bot] commented 1 year ago
Diff for 8021f9852f3ccb171b13b404c41f2a5029548592: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 49 validation infos, enable verbose output with '-v' to to display them. + add repository[name="puris"] { + allow_auto_merge = False + allow_forking = True + allow_merge_commit = True + allow_rebase_merge = True + allow_squash_merge = True + allow_update_branch = False + archived = False + default_branch = "main" + delete_branch_on_merge = True + dependabot_alerts_enabled = True + description = "Predictive Unit Real-Time Information Service (PURIS) for Short Term Demand and Capacity Management" + has_issues = True + has_projects = True + has_wiki = True + homepage = None + is_template = False + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "puris" + private = False + secret_scanning = "enabled" + secret_scanning_push_protection = "disabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = None + topics = [] + web_commit_signoff_required = False } + add branch_protection_rule[pattern="main", repository="puris"] { + allows_deletions = False + allows_force_pushes = False + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = False + is_admin_enforced = False + lock_allows_fetch_and_merge = False + lock_branch = False + pattern = "main" + push_restrictions = [] + require_last_push_approval = False + required_approving_review_count = "1" + required_status_checks = ['eclipse-eca-validation:eclipsefdn/eca'] + requires_approving_reviews = True + requires_code_owner_reviews = False + requires_commit_signatures = False + requires_conversation_resolution = False + requires_deployments = False + requires_linear_history = False + requires_status_checks = True + requires_strict_status_checks = True + restricts_review_dismissals = False } Plan: 2 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -423,7 +423,6 @@ branch_protection_rules: [ orgs.newBranchProtectionRule('main') { required_approving_review_count: 1, - requires_status_checks: true, requires_strict_status_checks: true, }, ], @@ -451,7 +450,6 @@ web_commit_signoff_required: false, }, orgs.newRepo('sig-project-management') { - aliases: ['sig-project-managment'], allow_update_branch: false, secret_scanning_push_protection: "disabled", web_commit_signoff_required: false, ```
netomi commented 1 year ago

so the eca check is now enforced:

+ required_status_checks = ['eclipse-eca-validation:eclipsefdn/eca']

minor nitpick that you see from the canonical view:

- requires_status_checks: true,

the setting could be removed from your own config as it is inherited already from the default, so you only need to specify it if you want to explicitly disable it.

mhellmeier commented 1 year ago

minor nitpick that you see from the canonical view:

- requires_status_checks: true,

the setting could be removed from your own config as it is inherited already from the default, so you only need to specify it if you want to explicitly disable it.

On the other hand, if the default configuration changes from requires_status_checks: true to requires_status_checks: false and we want to enable it explicitly, we wouldn't notice it. Therefore, leaving it in the configuration ensures it.

So is it still okay or should I remove the line?

netomi commented 1 year ago

On the other hand, if the default configuration changes from requires_status_checks: true to requires_status_checks: false and we want to enable it explicitly, we wouldn't notice it. Therefore, leaving it in the configuration ensures it.

So is it still okay or should I remove the line?

indeed, that's why we will not do anything like that in the default config. If this will ever happen, we will tag the default config. Right now, it still points to the main branch, but this will change soon.

github-actions[bot] commented 1 year ago
Diff for 467b2f8f691118210fed488c2df3bd906dc8d8d4: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 49 validation infos, enable verbose output with '-v' to to display them. + add repository[name="puris"] { + allow_auto_merge = False + allow_forking = True + allow_merge_commit = True + allow_rebase_merge = True + allow_squash_merge = True + allow_update_branch = False + archived = False + default_branch = "main" + delete_branch_on_merge = True + dependabot_alerts_enabled = True + description = "Predictive Unit Real-Time Information Service (PURIS) for Short Term Demand and Capacity Management" + has_issues = True + has_projects = True + has_wiki = True + homepage = None + is_template = False + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "puris" + private = False + secret_scanning = "enabled" + secret_scanning_push_protection = "disabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = None + topics = [] + web_commit_signoff_required = False } + add branch_protection_rule[pattern="main", repository="puris"] { + allows_deletions = False + allows_force_pushes = False + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = False + is_admin_enforced = False + lock_allows_fetch_and_merge = False + lock_branch = False + pattern = "main" + push_restrictions = [] + require_last_push_approval = False + required_approving_review_count = "1" + required_status_checks = ['eclipse-eca-validation:eclipsefdn/eca'] + requires_approving_reviews = True + requires_code_owner_reviews = False + requires_commit_signatures = False + requires_conversation_resolution = False + requires_deployments = False + requires_linear_history = False + requires_status_checks = True + requires_strict_status_checks = True + restricts_review_dismissals = False } Plan: 2 to add, 0 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -450,7 +450,6 @@ web_commit_signoff_required: false, }, orgs.newRepo('sig-project-management') { - aliases: ['sig-project-managment'], allow_update_branch: false, secret_scanning_push_protection: "disabled", web_commit_signoff_required: false, ```
Siegfriedk commented 1 year ago

Sry for the delay, i was pretty sure i was approving it yesterday. @netomi good to merge from my side as project lead (not technical, not sure if everything is setup correctly)

netomi commented 1 year ago

change has been applied and repo has been created. It might take 1-2 hours for the permissions to setup correctly (done by another script that runs on a regular basis).