Closed mhellmeier closed 1 year ago
@Siegfriedk : Can you review, please?
CC: @AngelikaWittek
so the eca check is now enforced:
+ required_status_checks = ['eclipse-eca-validation:eclipsefdn/eca']
minor nitpick that you see from the canonical view:
- requires_status_checks: true,
the setting could be removed from your own config as it is inherited already from the default, so you only need to specify it if you want to explicitly disable it.
minor nitpick that you see from the canonical view:
- requires_status_checks: true,
the setting could be removed from your own config as it is inherited already from the default, so you only need to specify it if you want to explicitly disable it.
On the other hand, if the default configuration changes from requires_status_checks: true
to requires_status_checks: false
and we want to enable it explicitly, we wouldn't notice it. Therefore, leaving it in the configuration ensures it.
So is it still okay or should I remove the line?
On the other hand, if the default configuration changes from
requires_status_checks: true
torequires_status_checks: false
and we want to enable it explicitly, we wouldn't notice it. Therefore, leaving it in the configuration ensures it.So is it still okay or should I remove the line?
indeed, that's why we will not do anything like that in the default config. If this will ever happen, we will tag the default config. Right now, it still points to the main branch, but this will change soon.
Sry for the delay, i was pretty sure i was approving it yesterday. @netomi good to merge from my side as project lead (not technical, not sure if everything is setup correctly)
change has been applied and repo has been created. It might take 1-2 hours for the permissions to setup correctly (done by another script that runs on a regular basis).
Description
As discussed in the Eclipse help desk ticket 3385, we would like to merge the
puris-frontend
andpuris-backend
repository into a newpuris
repository.This pull requests updates the otterdog configuration to add the new repo.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: