eclipse-tractusx / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-tractusx.github.io/.eclipsefdn/
1 stars 15 forks source link

chore: remove puris-frontend and puris-backend repo #16

Closed mhellmeier closed 1 year ago

mhellmeier commented 1 year ago

As discussed in #10, the new puris repository substitutes the old repos puris-frontend and puris-backend. Since the new repository is created including an initial contribution in https://github.com/eclipse-tractusx/puris/pull/1, the old repositories aren't used anymore and can therefore be deleted.

github-actions[bot] commented 1 year ago
Diff for 3f3ab07598142ffe1ad2aacc176137c302b96a80: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 37 validation infos, enable verbose output with '-v' to to display them. - remove repository[name="puris-backend"] { - allow_auto_merge = false - allow_forking = true - allow_merge_commit = true - allow_rebase_merge = true - allow_squash_merge = true - allow_update_branch = false - archived = false - default_branch = "main" - delete_branch_on_merge = false - dependabot_alerts_enabled = true - dependabot_security_updates_enabled = false - description = "puris-backend" - gh_pages_build_type = "disabled" - has_discussions = false - has_issues = true - has_projects = true - has_wiki = true - homepage = null - is_template = false - merge_commit_message = "PR_TITLE" - merge_commit_title = "MERGE_MESSAGE" - name = "puris-backend" - private = false - secret_scanning = "enabled" - secret_scanning_push_protection = "disabled" - squash_merge_commit_message = "COMMIT_MESSAGES" - squash_merge_commit_title = "COMMIT_OR_PR_TITLE" - template_repository = null - topics = [] - web_commit_signoff_required = false - } - remove repository[name="puris-frontend"] { - allow_auto_merge = false - allow_forking = true - allow_merge_commit = true - allow_rebase_merge = true - allow_squash_merge = true - allow_update_branch = false - archived = false - default_branch = "main" - delete_branch_on_merge = false - dependabot_alerts_enabled = true - dependabot_security_updates_enabled = false - description = "puris-frontend" - gh_pages_build_type = "disabled" - has_discussions = false - has_issues = true - has_projects = true - has_wiki = true - homepage = null - is_template = false - merge_commit_message = "PR_TITLE" - merge_commit_title = "MERGE_MESSAGE" - name = "puris-frontend" - private = false - secret_scanning = "enabled" - secret_scanning_push_protection = "disabled" - squash_merge_commit_message = "COMMIT_MESSAGES" - squash_merge_commit_title = "COMMIT_OR_PR_TITLE" - template_repository = null - topics = [] - web_commit_signoff_required = false - } Plan: 0 to add, 0 to change, 2 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] ```
github-actions[bot] commented 1 year ago
Diff for bf7776351b126f2f89640458c7339710a7b89e82: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 37 validation infos, enable verbose output with '-v' to to display them. - remove repository[name="puris-backend"] { - allow_auto_merge = false - allow_forking = true - allow_merge_commit = true - allow_rebase_merge = true - allow_squash_merge = true - allow_update_branch = false - archived = false - default_branch = "main" - delete_branch_on_merge = false - dependabot_alerts_enabled = true - dependabot_security_updates_enabled = false - description = "puris-backend" - gh_pages_build_type = "disabled" - has_discussions = false - has_issues = true - has_projects = true - has_wiki = true - homepage = null - is_template = false - merge_commit_message = "PR_TITLE" - merge_commit_title = "MERGE_MESSAGE" - name = "puris-backend" - private = false - secret_scanning = "enabled" - secret_scanning_push_protection = "disabled" - squash_merge_commit_message = "COMMIT_MESSAGES" - squash_merge_commit_title = "COMMIT_OR_PR_TITLE" - template_repository = null - topics = [] - web_commit_signoff_required = false - } - remove repository[name="puris-frontend"] { - allow_auto_merge = false - allow_forking = true - allow_merge_commit = true - allow_rebase_merge = true - allow_squash_merge = true - allow_update_branch = false - archived = false - default_branch = "main" - delete_branch_on_merge = false - dependabot_alerts_enabled = true - dependabot_security_updates_enabled = false - description = "puris-frontend" - gh_pages_build_type = "disabled" - has_discussions = false - has_issues = true - has_projects = true - has_wiki = true - homepage = null - is_template = false - merge_commit_message = "PR_TITLE" - merge_commit_title = "MERGE_MESSAGE" - name = "puris-frontend" - private = false - secret_scanning = "enabled" - secret_scanning_push_protection = "disabled" - squash_merge_commit_message = "COMMIT_MESSAGES" - squash_merge_commit_title = "COMMIT_OR_PR_TITLE" - template_repository = null - topics = [] - web_commit_signoff_required = false - } Plan: 0 to add, 0 to change, 2 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] ```
netomi commented 1 year ago

I would suggest to archive the repo (see https://otterdog.readthedocs.io/en/latest/reference/organization/repository/), using archived: true .

At a later time, these repos can still be removed if needed. So far the puris repo is still empty as the PR to initialize it has not been approved yet.

mhellmeier commented 1 year ago

Just set the archive option as suggested. It would be great if you could review it again, @netomi.

github-actions[bot] commented 1 year ago
Diff for c878779317c9b0f78363fd83e6e702b527b6d3d3: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 37 validation infos, enable verbose output with '-v' to to display them. ! repository[name="puris-backend"] { ! archived = false -> true ! } ! repository[name="puris-frontend"] { ! archived = false -> true ! } Plan: 0 to add, 2 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -408,17 +408,13 @@ web_commit_signoff_required: false } orgs.newRepo('puris-backend') { - allow_update_branch: false archived: true description: "puris-backend" - secret_scanning_push_protection: "disabled" web_commit_signoff_required: false } orgs.newRepo('puris-frontend') { - allow_update_branch: false archived: true description: "puris-frontend" - secret_scanning_push_protection: "disabled" web_commit_signoff_required: false } orgs.newRepo('sd-factory') { ```
netomi commented 1 year ago

change LGTM. However is this change coordinated with the infra team? I am not aware how the project handles itself, but there seems to be a separate team and repo with stuff like that: https://github.com/eclipse-tractusx/sig-infra/issues

It would be good if requests are approved there and then referenced to PRs here, that way we could speed up the process imho.

@SebastianBezold @Siegfriedk would do you think about that?

Siegfriedk commented 1 year ago

@netomi yes this is our workflow you linked and we are currently trying to refine it with the documentation and issue flow.

Good suggestion to have an issue on our repo first.

Might take a few days to write it down, we are in the middle of a release and holiday season

netomi commented 1 year ago

The open PR has been merged, I will now also apply this change.

netomi commented 1 year ago

change has been applied, the 2 repos have been archived.