Closed evegufy closed 1 year ago
change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.
Could a second committer / project-lead approve these changes?
change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.
Could a second committer / project-lead approve these changes?
@netomi Thank you, I removed the setting for the default branch.
@Siegfriedk Could you please give your approval as project lead?
change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick. Could a second committer / project-lead approve these changes?
@netomi Thank you, I removed the setting for the default branch.
@Siegfriedk Could you please give your approval as project lead?
@SebastianBezold Could you please give your approval? Sigi is on leave I heard.
Hi,
from my point of view the description and branch protection rules are fine, but I'm not sure, if a PL (@giterrific, @danielmiehle, @Siegfriedk) approval is needed.
Considering the type of changes, another approval from a fellow committer are enough imho. I will merge at as is.
changes have been applied.
Description
update repository settings for portal-repository:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: