search

eclipse-tractusx / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-tractusx.github.io/.eclipsefdn/
1 stars 15 forks source link

chore: update settings for portal repos #23

Closed evegufy closed 1 year ago

evegufy commented 1 year ago

Description

update repository settings for portal-repository:

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-actions[bot] commented 1 year ago
Diff for 1b584692f430f361a13db830594e89bee8be3a23: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 39 validation infos, enable verbose output with '-v' to to display them. ! repository[name="portal-assets"] { ! description = null -> "Portal Assets" ! } ! repository[name="portal-backend"] { ! default_branch = "dev" -> "main" ! description = null -> "Portal Backend" ! } ! repository[name="portal-cd"] { ! default_branch = "dev" -> "main" ! description = "portal cd" -> "Portal - Continuous Deployment" ! } ! repository[name="portal-frontend"] { ! default_branch = "dev" -> "main" ! description = null -> "Portal Frontend" ! } ! repository[name="portal-frontend-registration"] { ! default_branch = "dev" -> "main" ! description = null -> "Portal Frontend Registration" ! } ! repository[name="portal-iam"] { ! delete_branch_on_merge = false -> true ! description = "portal iam" -> "IAM - Keycloak instances" ! } + add branch_protection_rule[pattern="main", repository="portal-iam"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = true + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + push_restrictions = [] + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } ! repository[name="portal-shared-components"] { ! delete_branch_on_merge = false -> true ! description = null -> "Portal Shared UI Components" ! } + add branch_protection_rule[pattern="main", repository="portal-shared-components"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = true + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + push_restrictions = [] + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } Plan: 2 to add, 13 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -298,6 +298,7 @@ requires_strict_status_checks: true } ] + default_branch: "main" delete_branch_on_merge: true description: "Portal Backend" secret_scanning_push_protection: "disabled" @@ -324,6 +325,7 @@ requires_strict_status_checks: true } ] + default_branch: "main" delete_branch_on_merge: true description: "Portal - Continuous Deployment" secret_scanning_push_protection: "disabled" @@ -345,6 +347,7 @@ requires_strict_status_checks: true } ] + default_branch: "main" delete_branch_on_merge: true description: "Portal Frontend" secret_scanning_push_protection: "disabled" @@ -366,6 +369,7 @@ requires_strict_status_checks: true } ] + default_branch: "main" delete_branch_on_merge: true description: "Portal Frontend Registration" secret_scanning_push_protection: "disabled" @@ -429,13 +433,17 @@ web_commit_signoff_required: false } orgs.newRepo('puris-backend') { + allow_update_branch: false archived: true description: "puris-backend" + secret_scanning_push_protection: "disabled" web_commit_signoff_required: false } orgs.newRepo('puris-frontend') { + allow_update_branch: false archived: true description: "puris-frontend" + secret_scanning_push_protection: "disabled" web_commit_signoff_required: false } orgs.newRepo('sd-factory') { ```
netomi commented 1 year ago

change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.

Could a second committer / project-lead approve these changes?

github-actions[bot] commented 1 year ago
Diff for 597e9085fd1eb92d7b54293861830a1e7571a3e7: ```diff Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 39 validation infos, enable verbose output with '-v' to to display them. ! repository[name="portal-assets"] { ! description = null -> "Portal Assets" ! } ! repository[name="portal-backend"] { ! default_branch = "dev" -> "main" ! description = null -> "Portal Backend" ! } ! repository[name="portal-cd"] { ! default_branch = "dev" -> "main" ! description = "portal cd" -> "Portal - Continuous Deployment" ! } ! repository[name="portal-frontend"] { ! default_branch = "dev" -> "main" ! description = null -> "Portal Frontend" ! } ! repository[name="portal-frontend-registration"] { ! default_branch = "dev" -> "main" ! description = null -> "Portal Frontend Registration" ! } ! repository[name="portal-iam"] { ! delete_branch_on_merge = false -> true ! description = "portal iam" -> "IAM - Keycloak instances" ! } + add branch_protection_rule[pattern="main", repository="portal-iam"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = true + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + push_restrictions = [] + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } ! repository[name="portal-shared-components"] { ! delete_branch_on_merge = false -> true ! description = null -> "Portal Shared UI Components" ! } + add branch_protection_rule[pattern="main", repository="portal-shared-components"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = true + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + push_restrictions = [] + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } Plan: 2 to add, 13 to change, 0 to delete. ``` ```diff Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json' Organization eclipse-tractusx[id=eclipse-tractusx] --- original +++ canonical @@ -429,13 +429,17 @@ web_commit_signoff_required: false } orgs.newRepo('puris-backend') { + allow_update_branch: false archived: true description: "puris-backend" + secret_scanning_push_protection: "disabled" web_commit_signoff_required: false } orgs.newRepo('puris-frontend') { + allow_update_branch: false archived: true description: "puris-frontend" + secret_scanning_push_protection: "disabled" web_commit_signoff_required: false } orgs.newRepo('sd-factory') { ```
evegufy commented 1 year ago

change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick.

Could a second committer / project-lead approve these changes?

@netomi Thank you, I removed the setting for the default branch.

@Siegfriedk Could you please give your approval as project lead?

evegufy commented 1 year ago

change LTGM, when you change the default branch to main, you can just remove the setting completely, as it already defined in the default, but thats just a minor nitpick. Could a second committer / project-lead approve these changes?

@netomi Thank you, I removed the setting for the default branch.

@Siegfriedk Could you please give your approval as project lead?

@SebastianBezold Could you please give your approval? Sigi is on leave I heard.

SebastianBezold commented 1 year ago

Hi,

from my point of view the description and branch protection rules are fine, but I'm not sure, if a PL (@giterrific, @danielmiehle, @Siegfriedk) approval is needed.

netomi commented 1 year ago

Considering the type of changes, another approval from a fellow committer are enough imho. I will merge at as is.

netomi commented 1 year ago

changes have been applied.