eclipse-tractusx / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-tractusx.github.io/.eclipsefdn/
1 stars 14 forks source link

chore: request new repo 'tractusx-profiles' #48

Closed paullatzelsperger closed 5 months ago

paullatzelsperger commented 5 months ago

Description

This PR requests a new repository named 'tx-profiles'.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-actions[bot] commented 5 months ago
Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Printing local diff: Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 41 validation infos, enable verbose output with '-v' to to display them. + add repository[name="tx-profiles"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = null + gh_pages_build_type = "legacy" + gh_pages_source_branch = "gh-pages" + gh_pages_source_path = "/" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = true + homepage = null + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "tx-profiles" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [] + web_commit_signoff_required = false + } + add repo_workflow_settings[repository="tx-profiles"] { + actions_can_approve_pull_request_reviews = true + default_workflow_permissions = "write" + enabled = true + } + add environment[name="github-pages", repository="tx-profiles"] { + branch_policies = [ + "gh-pages" + ], + deployment_branch_policy = "selected" + name = "github-pages" + reviewers = [] + wait_timer = "0" + } Plan: 3 to add, 0 to change, 0 to delete. ```
Canonical Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Showing canonical diff: Organization eclipse-tractusx[id=eclipse-tractusx] ```
github-actions[bot] commented 5 months ago
Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Printing local diff: Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 41 validation infos, enable verbose output with '-v' to to display them. + add repository[name="tx-profiles"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = null + gh_pages_build_type = "legacy" + gh_pages_source_branch = "gh-pages" + gh_pages_source_path = "/" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = true + homepage = null + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "tx-profiles" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [] + web_commit_signoff_required = false + } + add repo_workflow_settings[repository="tx-profiles"] { + actions_can_approve_pull_request_reviews = true + default_workflow_permissions = "read" + enabled = true + } + add environment[name="github-pages", repository="tx-profiles"] { + branch_policies = [ + "gh-pages" + ], + deployment_branch_policy = "selected" + name = "github-pages" + reviewers = [] + wait_timer = "0" + } Plan: 3 to add, 0 to change, 0 to delete. ```
Canonical Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Showing canonical diff: Organization eclipse-tractusx[id=eclipse-tractusx] --- canonical +++ original @@ -1100,9 +1100,6 @@ gh_pages_source_path: "/" has_discussions: true web_commit_signoff_required: false - workflows+: { - default_workflow_permissions: "read" - } } orgs.newRepo('vas-country-risk') { allow_merge_commit: true ```
github-actions[bot] commented 5 months ago
Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Printing local diff: Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 41 validation infos, enable verbose output with '-v' to to display them. + add repository[name="tx-profiles"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = null + gh_pages_build_type = "legacy" + gh_pages_source_branch = "gh-pages" + gh_pages_source_path = "/" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = true + homepage = null + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "tx-profiles" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [] + web_commit_signoff_required = false + } + add repo_workflow_settings[repository="tx-profiles"] { + actions_can_approve_pull_request_reviews = true + default_workflow_permissions = "read" + enabled = true + } + add environment[name="github-pages", repository="tx-profiles"] { + branch_policies = [ + "gh-pages" + ], + deployment_branch_policy = "selected" + name = "github-pages" + reviewers = [] + wait_timer = "0" + } Plan: 3 to add, 0 to change, 0 to delete. ```
Canonical Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Showing canonical diff: Organization eclipse-tractusx[id=eclipse-tractusx] ```
netomi commented 5 months ago

LGTM, can someone else give an approval?

FaGru3n commented 5 months ago

Hi @paullatzelsperger,

is there a reason why naming it "tx-profiles" ?

paullatzelsperger commented 5 months ago

Yes because it'll contain resources such as verifiable credentials, json-ld contexts and policies for tractus-x. However, they will have to be namespaced to a particular dataspace (eg catena x). And we plan to represent that as profiles.

FaGru3n commented 5 months ago

Yes because it'll contain resources such as verifiable credentials, json-led contexts and policies for tractus-x. However, they will have to be namespaced to a particular dataspace (eg catena x). And we plan to represent that as profiles.

seems legit, but to prevent missunderstanding with our fork naming patterns within catena-x i guess prefix "tx-" should be improved

paullatzelsperger commented 5 months ago

seems legit, but to prevent missunderstanding with our fork naming patterns within catena-x i guess prefix "tx-" should be improved

calling it just "profiles" seems a bit too generic. where can I find those fork naming patterns?

FaGru3n commented 5 months ago

seems legit, but to prevent missunderstanding with our fork naming patterns within catena-x i guess prefix "tx-" should be improved

calling it just "profiles" seems a bit too generic. where can I find those fork naming patterns?

https://github.com/catenax-ng?q=tx-&type=all&language=&sort= and some internal system team instruction https://catenax-ng.github.io/docs/internal/how-to-setup-forked-repo

paullatzelsperger commented 5 months ago

seems legit, but to prevent missunderstanding with our fork naming patterns within catena-x i guess prefix "tx-" should be improved

calling it just "profiles" seems a bit too generic. where can I find those fork naming patterns?

https://github.com/catenax-ng?q=tx-&type=all&language=&sort= and some internal system team instruction https://catenax-ng.github.io/docs/internal/how-to-setup-forked-repo

I honestly don't know how it would be possible for anyone to confuse an upstream repo with a fork, and I don't see how (formally) the catenax-ng repo has any influence on tractusx. but ok, then "tractusx-profiles" will be better.

FaGru3n commented 5 months ago

seems legit, but to prevent missunderstanding with our fork naming patterns within catena-x i guess prefix "tx-" should be improved

calling it just "profiles" seems a bit too generic. where can I find those fork naming patterns?

https://github.com/catenax-ng?q=tx-&type=all&language=&sort= and some internal system team instruction https://catenax-ng.github.io/docs/internal/how-to-setup-forked-repo

I honestly don't know how it would be possible for anyone to confuse an upstream repo with a fork, and I don't see how (formally) the catenax-ng repo has any influence on tractusx. but ok, then "tractusx-profiles" will be better.

where also my suggestions:

github-actions[bot] commented 5 months ago
Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Printing local diff: Actions are indicated with the following symbols: + create ! modify ! forced update - delete Organization eclipse-tractusx[id=eclipse-tractusx] there have been 41 validation infos, enable verbose output with '-v' to to display them. + add repository[name="tractusx-profiles"] { + allow_auto_merge = false + allow_forking = true + allow_merge_commit = true + allow_rebase_merge = true + allow_squash_merge = true + allow_update_branch = false + archived = false + default_branch = "main" + delete_branch_on_merge = false + dependabot_alerts_enabled = true + dependabot_security_updates_enabled = false + description = null + gh_pages_build_type = "legacy" + gh_pages_source_branch = "gh-pages" + gh_pages_source_path = "/" + has_discussions = true + has_issues = true + has_projects = true + has_wiki = true + homepage = null + is_template = false + merge_commit_message = "PR_TITLE" + merge_commit_title = "MERGE_MESSAGE" + name = "tractusx-profiles" + private = false + secret_scanning = "enabled" + secret_scanning_push_protection = "enabled" + squash_merge_commit_message = "COMMIT_MESSAGES" + squash_merge_commit_title = "COMMIT_OR_PR_TITLE" + template_repository = null + topics = [] + web_commit_signoff_required = false + } + add repo_workflow_settings[repository="tractusx-profiles"] { + actions_can_approve_pull_request_reviews = true + default_workflow_permissions = "read" + enabled = true + } + add environment[name="github-pages", repository="tractusx-profiles"] { + branch_policies = [ + "gh-pages" + ], + deployment_branch_policy = "selected" + name = "github-pages" + reviewers = [] + wait_timer = "0" + } Plan: 3 to add, 0 to change, 0 to delete. ```
Canonical Diff for 5840580a5ceeb95dcb4bb8525eadba29be115076: ```diff Showing canonical diff: Organization eclipse-tractusx[id=eclipse-tractusx] ```
netomi commented 5 months ago

changes are live.

Siegfriedk commented 5 months ago

@netomi pls aks for project lead verification for repository creation