Closed almadigabor closed 1 year ago
Ty for the PR. Enabling github pages via adding a corresponding environment has not been tested yet. I will see if this already sufficient or more work is needed (see https://gitlab.eclipse.org/eclipsefdn/security/otterdog/-/issues/59).
I will merge your PR and apply. If some additional config is needed to enable GH Pages I will do it manually via the UI for the time being.
The change has been applied and the environment has been created. GitHub Pages configuration for the repo is still set to Deploy from branch with None selected atm.
Please let me know how you plan to deploy to GitHub Pages so that we can enable the missing things.
@almadigabor It looks like you use this action to deploy to GitHub Pages:
From there I see that the https://github.com/helm/chart-releaser-action is being use to commit the charts to a gh-pages branch from which it shall be deployed. This is also listed in the prerequisites of the action.
Can you please create an empty gh-pages branch in the project as explained here:
https://jiafulow.github.io/blog/2020/07/09/create-gh-pages-branch-in-existing-repo/
After that I can setup that GitHub Pages is deployed from the gh-pages branch, support for that is missing in otterdog atm, but will work on adding that via the configuration.
Looking at repo https://github.com/eclipse-tractusx/item-relationship-service, I can see that the gh-pages branch seems to be based on main, so creating an empty branch is maybe not necessary, just creating a gh-pages branch will probably suffice.
Hi @netomi! Thanks for the help! I created the gh-pages branch based on the main branch and rerun the failed GH Action. To test it in action we need the team to make some changes to the helm chart in their repository because rerunning the workflow currently succeeds but does not do anything at all as changes are not detected on the chart. I'll keep on checking and let you know if it still won't work.
Ok thanks, I have configured the data-exchange-test-service now manually such that GitHub Pages are deployed from the gh-pages branch. That was missing and you can only set it in the UI once the branch exists. This is something that should also be configurable using otterdog.
deployment seems to work fine: https://eclipse-tractusx.github.io/data-exchange-test-service/
name: Enable GitHub Pages for data-exchange-test-service about: 'Currently branch does not exist and GH Pages are disabled so helm repository is not available and helm chart is not released properly' title: 'chore: enable gh-pages for data-exchange-test-service'
Description
Thanks for opening this contribution! What does this PR introduce? Does it fix a bug? Does it add a new feature? Is it enhancing documentation?
Currently branch does not exist and GH Pages are disabled so helm repository is not available and helm chart is not released properly
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
Additional information