eclipse-tractusx / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-tractusx.github.io/.eclipsefdn/
1 stars 19 forks source link

chore: enable branch protection rule and other configurations on digital-product-pass main branch #86

Closed saudkhan116 closed 5 months ago

saudkhan116 commented 5 months ago

Description

FYI @stephanbcbauer

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization. You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

Otterdog commands and options You can trigger otterdog actions by commenting on this PR: - `/otterdog team-info` checks the team / org membership for the PR author - `/otterdog validate` validates the configuration change - `/otterdog validate info` validates the configuration change, printing also validation infos - `/otterdog check-sync` checks if the base ref is in sync with live settings - `/otterdog merge` merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author) - `/otterdog done` notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team) - `/otterdog apply` re-apply a previously failed attempt (only accessible for members of the admin team)
eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot.

The author (saudkhan116) of this PR is associated with this organization in the role of MEMBER.

Additionally, saudkhan116 is a member of the following teams:

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for b25ec1985b0f422ddcf74f9a48d0bea4fc837564 ```diff Organization automotive.tractusx[id=eclipse-tractusx] ╷ │ Error: failed to load configuration │ │ failed to evaluate jsonnet file: /app/work/tmp/tmpeh0txx59/eclipse-tractusx/eclipse-tractusx.jsonnet:276:7-34 Duplicate field: web_commit_signoff_required │ │ web_commit_signoff_required: false, │ ╵ ```
eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. The current configuration is out-of-sync with the live settings:

Diff to live settings ```diff Organization automotive.tractusx[id=eclipse-tractusx] there have been 64 validation infos, enable verbose output with '-v' to to display them. ! repository[name="sig-release"] { ! allow_update_branch = true -> false ! } Plan: 0 to add, 1 to change, 0 to delete. ```

The current configuration needs to be updated to reflect the live settings otherwise they would be overwritten when this PR gets merged.

cc @eclipse-tractusx/eclipsefdn-security

cc @eclipse-tractusx/eclipsefdn-releng

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 1b726abcea33c30c708f267f473c854d78f7a649 ```diff Organization automotive.tractusx[id=eclipse-tractusx] ╷ │ Warning: repository[name="digital-product-pass"] has 'gh_pages_build_type' with value 'legacy' but no corresponding 'github-pages' environment, please add such an environment. ╵ there have been 65 validation infos, enable verbose output with '-v' to to display them. ! repository[name="digital-product-pass"] { ! dependabot_security_updates_enabled = false -> true ! gh_pages_build_type = "disabled" -> "legacy" ! gh_pages_source_branch = null -> "gh-pages" ! gh_pages_source_path = "/" -> "/" ! has_discussions = false -> true ! homepage = null -> "https://github.com/eclipse-tractusx/digital-product-pass" ! } + add branch_protection_rule[pattern="main", repository="digital-product-pass"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = false + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } Plan: 1 to add, 6 to change, 0 to delete. ```
eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. The current configuration is out-of-sync with the live settings:

Diff to live settings ```diff Organization automotive.tractusx[id=eclipse-tractusx] there have been 64 validation infos, enable verbose output with '-v' to to display them. ! repository[name="sig-release"] { ! allow_update_branch = true -> false ! } Plan: 0 to add, 1 to change, 0 to delete. ```

The current configuration needs to be updated to reflect the live settings otherwise they would be overwritten when this PR gets merged.

cc @eclipse-tractusx/eclipsefdn-security

cc @eclipse-tractusx/eclipsefdn-releng

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 23d63a927001536b557278def75e9b05e4417f81 ```diff Organization automotive.tractusx[id=eclipse-tractusx] ╷ │ Warning: repository[name="digital-product-pass"] has 'gh_pages_build_type' with value 'legacy' but no corresponding 'github-pages' environment, please add such an environment. ╵ there have been 65 validation infos, enable verbose output with '-v' to to display them. ! repository[name="digital-product-pass"] { ! dependabot_security_updates_enabled = false -> true ! gh_pages_build_type = "disabled" -> "legacy" ! gh_pages_source_branch = null -> "gh-pages" ! gh_pages_source_path = "/" -> "/" ! has_discussions = false -> true ! homepage = null -> "https://github.com/eclipse-tractusx/digital-product-pass" ! } + add branch_protection_rule[pattern="main", repository="digital-product-pass"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = false + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } Plan: 1 to add, 6 to change, 0 to delete. ```
eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 3c7096a8936bbf2f3720b953f7c94c8b5b98fc4c ```diff Organization automotive.tractusx[id=eclipse-tractusx] there have been 65 validation infos, enable verbose output with '-v' to to display them. ! repository[name="digital-product-pass"] { ! dependabot_security_updates_enabled = false -> true ! gh_pages_build_type = "disabled" -> "legacy" ! gh_pages_source_branch = null -> "gh-pages" ! gh_pages_source_path = "/" -> "/" ! has_discussions = false -> true ! homepage = null -> "https://github.com/eclipse-tractusx/digital-product-pass" ! } + add environment[name="github-pages", repository="digital-product-pass"] { + branch_policies = [ + "gh-pages" + ], + deployment_branch_policy = "selected" + name = "github-pages" + reviewers = [] + wait_timer = "0" + } + add branch_protection_rule[pattern="main", repository="digital-product-pass"] { + allows_deletions = false + allows_force_pushes = false + blocks_creations = false + bypass_force_push_allowances = [] + bypass_pull_request_allowances = [] + dismisses_stale_reviews = false + is_admin_enforced = false + lock_allows_fetch_and_merge = false + lock_branch = false + pattern = "main" + require_last_push_approval = false + required_approving_review_count = "1" + requires_code_owner_reviews = false + requires_commit_signatures = false + requires_conversation_resolution = false + requires_deployments = false + requires_linear_history = false + requires_pull_request = true + requires_status_checks = false + restricts_pushes = false + restricts_review_dismissals = false + } Plan: 2 to add, 6 to change, 0 to delete. ```
netomi commented 5 months ago

LGTM, once approved by a PL you can merge yourself, follow the instructions that will be added as comment.

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

eclipse-otterdog[bot] commented 5 months ago

This is your friendly self-service bot.

The following changes have been successfully applied:


Organization automotive.tractusx[id=eclipse-tractusx]
  there have been 65 validation infos, enable verbose output with '-v' to to display them.

!   repository[name="digital-product-pass"] {
!     dependabot_security_updates_enabled = false -> true
!     gh_pages_build_type               = "disabled" -> "legacy"
!     gh_pages_source_branch            = null -> "gh-pages"
!     gh_pages_source_path              = "/" -> "/"
!     has_discussions                   = false -> true
!     homepage                          = null -> "https://github.com/eclipse-tractusx/digital-product-pass"
!   }

+  add environment[name="github-pages", repository="digital-product-pass"] {
+    branch_policies                   = [
+      "gh-pages"
+    ],
+    deployment_branch_policy          = "selected"
+    name                              = "github-pages"
+    reviewers                         = []
+    wait_timer                        = "0"
+  }

+  add branch_protection_rule[pattern="main", repository="digital-product-pass"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "main"
+    require_last_push_approval        = false
+    required_approving_review_count   = "1"
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }

  Applying changes:

  Done.

  Executed plan: 2 added, 6 changed, 0 deleted.