eclipse-tractusx / SSI-agent-lib

Apache License 2.0
3 stars 14 forks source link

`JsonWebSignature2020` required header fields seem to be missing #32

Open matgnt opened 10 months ago

matgnt commented 10 months ago

I've been debugging some MIW credentials and the header of the jws seems to look like this:

{"alg": "EdDSA"}

According to:

https://w3c.github.io/vc-jws-2020/#json-web-signature-2020

the header should contain a bit more: I used this one here to compare: https://github.com/decentralized-identity/JWS-Test-Suite/blob/39547f5dc6da289a3f7e460fd6b782b9c9dc898b/data/presentations/presentation-1.json#L47

{"b64": false, "crit": ["b64"], "alg": "EdDSA"}

I think this is required for kind of backward compatibility, that implementations without support for detached sigs can recognize and fail because at least they understand the crit list of required fields.

-- Matthias Binzer

koptan commented 10 months ago

Assigned to @koptan,