search

eclipse-tractusx / SSI-agent-lib

Apache License 2.0
4 stars 15 forks source link

Refactor build/release workflow #65

Closed carslen closed 10 months ago

carslen commented 10 months ago

I know, you're in the middle of the transition to build/publish your artefacts. But I want to point out, that it is not sufficient to publish the cx-ssi-lib to maven central and create a corresponding GH tag in the eclipse-tractusx/cx-ssi-lib.

Please do the following instead:

Please refactor build/release workflow. Maybe the GH action release-please could help you building your build/release workflow.

Extra hint: Please maintain CHANGELOG.md file. You published at Maven Central, but your Changelog has no v0.17.0 but content in Unreleased.

related to eclipse-tractusx/managed-identity-wallet#167

borisrizov-zf commented 10 months ago

@carslen Thanks for the tips!

This release was both an experiment and a release, as the 23.12 overall release is pressing, I had to make sure we're able to make package releases which are available through Maven and make the MIW compliant with the TRGs.

I'll update the CHANGELOG.md to reflect the current state of the code and add an issue to track progress on the automation of the GitHub release process, as we have some catch-up to do code-wise.

borisrizov-zf commented 10 months ago

PRs #66 and #68 cover most of the points. Issue #67 is created to tackle the automation of the GH release.

Please advice if we can safely close this issue now.