eclipse-tractusx / SSI-agent-lib

Apache License 2.0
4 stars 15 forks source link

Feat: adding Proof Configuration to Signature #77

Closed koptan closed 6 months ago

koptan commented 10 months ago

Description

PR to include the proof configuration in the final hash during the process of creating and verifying the proof.

Therefore, the verification process should fail if any values in the Proof Configuration attributes change.

This PR should fix #34, also it's merge #38

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

koptan commented 10 months ago

@DominikPinsel @matgnt @borisrizov-zf @bjoern-arnold, please for your review.

matgnt commented 10 months ago

I would leave this to the others to review. I'm not a Java developer and don't know the libraries internal structure.

borisrizov-zf commented 7 months ago

@koptan you should rebase, because of #44

koptan commented 7 months ago

@borisrizov-zf Rebase is done, you can merge it 👍

borisrizov-zf commented 7 months ago

@koptan Hi, still many more files have the docs deleted, and the copyright year is not 2024. I haven't marked them explicitly, due to the sheer quantity of files. Please review them and fix these issues, before I can continue.

borisrizov-zf commented 7 months ago

@koptan can you point me in the right direction about the following:

verification method can be either a multibase string or a map, but I cannot see where transformation is taking place. The interface which binds these seems to be missing the option to easily extend to something like publicKeyJWK with an EC cipher. Am I missing something?

koptan commented 6 months ago

@borisrizov-zf transformation is happening in TransformedLinkedData, we accept any JsonLD object as parameter.

borisrizov-zf commented 6 months ago

@koptan Hi, the branch needs rebasing, you're out of sync with main.