eclipse-tractusx / SSI-agent-lib

Apache License 2.0
4 stars 15 forks source link

chore: new VerifiableCredentialDecorator model #87

Closed DominikPinsel closed 2 months ago

DominikPinsel commented 8 months ago

This is the first Pull Request of multiple ones to enable the SSI library, to handle Verifiable Credentials with Json-LD signature (internal) and JWT signature (external).

I assume that there will be multiple pull requests / changes necessary. This PR would be the initial one. In the following text I would like to outline the whole concept and then create follow PRs for the different parts.

Please tell me what you think. Not only about the introduced class, but also about the proposed changes.


Concept Verifiable Credential as JWT


Dominik Pinsel dominik.pinsel@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

borisrizov-zf commented 8 months ago

@mustafasalfiti hi, can you also participate, as you already have some insight into the JWT VC.

borisrizov-zf commented 7 months ago

I've read through your proposal and it seems that you've misinterpreted the specs. We only intend to represent the JSON-LD version of the VC in JWT, not to translate all fields to JWT. You can read more here: https://www.w3.org/TR/vc-data-model/#identifiers In the id section you'll find an example of a VC encoded as JWT.

DominikPinsel commented 2 months ago

I'm not sure anymore whether I've time in the next weeks to contribute all these changes. Therefore I would close this PR. If this is important for upcoming features please reach out and I will try to make some time.