Batch processing of task results

StWeisshaar commented 4 weeks ago

Description

As BPDM architect, I want that the Orchestrator is able to process a batch of task results that includes tasks which already proceeded into one of the next steps, so that the batch can be processed even if there is one outdated task.

Acceptance Criteria

[ ] A batch of task results is successfully processed even if it contains a task that already proceeded to the next step.
[ ] All open task results are processed. Outdated task results are ignored.

Additional Information

The underlying problem is that the state maintained in the orchestrator is not always in sync with the cleaning service. This causes batches of task results to contain both records that are in need of resolution and tasks that were already resolved. Currently the whole batch is rejected without any indicator which of the provided task results is problematic. Solving the underlying problem would make this issue obsolete.

StWeisshaar commented 1 week ago

@nicoprow Maybe the "Aborted" step state is related to our 400 error. When posting a result for an aborted task would the orchestrator return a 400 error? When using batches one aborted task could fail the whole batch. @dilipdhankecha2530 fyi

nicoprow commented 1 week ago

@nicoprow Maybe the "Aborted" step state is related to our 400 error. When posting a result for an aborted task would the orchestrator return a 400 error? When using batches one aborted task could fail the whole batch. @dilipdhankecha2530 fyi

The expected behaviour for the Orchestrator is to ignore resolutions to already aborted tasks. See test here

If you notice that the orchestrator still returns 400 for aborted tasks please feel free to open a nother bug issue and we will have a look into it.

nicoprow commented 1 week ago

@StWeisshaar recategorized this issue as a feature which will be provided in the 25.03. release. Pull request already provided (https://github.com/eclipse-tractusx/bpdm/pull/1091)

eclipse-tractusx / bpdm