search

eclipse-tractusx / bpdm

bpdm
Apache License 2.0
5 stars 15 forks source link

build(charts): increase BPDM charts app-version to 6.0.2 #984

Closed nicoprow closed 6 days ago

nicoprow commented 6 days ago

Description

This pull request increases the BPDM charts app-version to 6.0.2

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

nicoprow commented 6 days ago

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

SujitMBRDI commented 6 days ago

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

Yeah, last and latest tag in our repo currently 5.1.0-SNAPSHOT but which is in main, we cannot bump it up from there. can we go for 5.1.0 then? or do you see other option.

nicoprow commented 6 days ago

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

Yeah, last and latest tag in our repo currently 5.1.0-SNAPSHOT but which is in main, we cannot bump it up from there. can we go for 5.1.0 then? or do you see other option.

The workflow checks are just there to alert us of some problems that might be there in the pull request. If you can see as well that the version bump is correct and everything else about the charts is correct as well, you can approve anyway and we merge it

SujitMBRDI commented 6 days ago

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

Yeah, last and latest tag in our repo currently 5.1.0-SNAPSHOT but which is in main, we cannot bump it up from there. can we go for 5.1.0 then? or do you see other option.

The workflow checks are just there to alert us of some problems that might be there in the pull request. If you can see as well that the version bump is correct and everything else about the charts is correct as well, you can approve anyway and we merge it

Got confused as pull request is in draft state, thought merging this changes will not possible unless we fix linting checks. For patch version, i can see version bump for app and helm chart are correct.