eclipse-tractusx / demand-capacity-mgmt

Apache License 2.0
4 stars 6 forks source link

Clarify react-native usage #65

Closed SebastianBezold closed 8 months ago

SebastianBezold commented 8 months ago

There is an open 3rd party IP issue, where clarification is needed. See the issue comment.

I am wondering, where and why we need react-native, since I was under the impression, that we are building a webapp only.

FYI @ClosedSourcerer

SebastianBezold commented 8 months ago

Hi @ClosedSourcerer,

I cannot find any usage of react-naitive components. I also cannot find any hint in the commit, that added the react-native dependency initially. See commit

When removing the dependency from the list, I can at least build the app locally. Unfortunately there seem to be no tests, that could further verify that. Could you please find someone, who can verify, if this dependency can be removed without issues?

ClosedSourcerer commented 8 months ago

@SebastianBezold

I contacted to original authors. We should get a qualified answer within a week.

SebastianBezold commented 8 months ago

Hi @ClosedSourcerer,

did you already receive feedback from the original authors? I don't want to keep the EF ticket open for too long. If we cannot get an answer, I could also remove the dependency for now and leave the testing for someone picking up development in the future

ClosedSourcerer commented 8 months ago

@SebastianBezold

Not yet, I upgrade this Issue to an weekly escalation cycle.

Ruskyy commented 8 months ago

@SebastianBezold @ClosedSourcerer From my analysis, those seem to be remnant of a test library that is no longer being used of an old Chronogram component. Those can be safely deleted with no impact on the app. Sorry for the delay on the answer as i was on vacation and just caught up with this.

SebastianBezold commented 8 months ago

HI @Ruskyy, thanks for the update. Then I'll remove the lib and let the EF know on the 3rd party IP issue.

SebastianBezold commented 8 months ago

Removed in ab322a8