Closed SebastianBezold closed 7 months ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
HI @Ruskyy,
could you maybe check, why there are test failures for this build?
FYI @ClosedSourcerer
Please merge despite the testing errors. Because of the fact that the consortia is ending and the 24.05 breaking change it is important to have the code moved from catx-ng to tractusx.
Fixing this issues will be worked on after the tractusx community days.
Looking at the error it seems like the Github action was trying to run on a different java version.
We never faced this issue running locally, might be either a java or a maven prettier issue, since prettier does not support java natively and is based around a community plugin, I would recommend perhaps updating prettier to a new version and re run the pipelines.
HI @Bailonis and @Ruskyy,
same as mentioned in the comment on the documentation branch: Could you please check the GitGuardian issues raised for this PR.
@Ruskyy, restarting the build did not resolve the issue. If you already have a solution, please fix it in your workflows, or raise an issue with your research on it, so someone else can pick it up
Regarding the security checks, they all appear to be from settings from local development aswell. And EDC secrets are on the vault, not plaintext on the yaml.
As for the issue I will open it now.
@SebastianBezold
Filled in the issue structure with the findings from the repo of the prettier version running on the action.
https://github.com/eclipse-tractusx/demand-capacity-mgmt/issues/71
Regarding the security checks, they all appear to be from settings from local development aswell. And EDC secrets are on the vault, not plaintext on the yaml.
As for the issue I will open it now.
It is still important, that you provide feedback, since it does not matter, if a secret is leaked somewhere in history or on the current revision. If it can be misused, that's an issue, so providing feedback, if tokens and API keys have been rotated is important
Description
This PR contains the (so far) final development efforts made during the Catena-X consorita phase. Additional cleanup steps like proper dependency annotations and release guideline compliance have been done.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: