eclipse-tractusx / demand-capacity-mgmt

Apache License 2.0
4 stars 5 forks source link

Sad sad Panda (Records on maven-prettier) #71

Closed Ruskyy closed 4 months ago

Ruskyy commented 5 months ago

Current Behavior

Local development was never plagued by this sad sad panda issue. This is an issue by using prettier and using records in Java.

Expected Behavior

Github action goes well and no changes needed.

Steps To Reproduce

Just run the action and it will throw a prettier error on records.

How to fix

Revert back the exceptions, exception handling solution to an interface instead of using records. like the implementation below (NOTE: you need to adapt and match how it functions in the current implementation, only a code and last digits) main

OR (Recomended)

try to update pipeline the github action java-prettier version. Should fix the issue, as the current running version does not support records. Currrent action version: prettier-maven-plugin-0.13 Latest stable version: prettier-maven-plugin-0.22

See: https://github.com/HubSpot/prettier-maven-plugin/issues/69 Comment: https://github.com/HubSpot/prettier-maven-plugin/issues/69#issuecomment-1119829461