search

eclipse-tractusx / digital-product-pass

digital product pass
https://github.com/eclipse-tractusx/digital-product-pass
Apache License 2.0
22 stars 12 forks source link

[ 22° ] - Release/v2.1.0/user manual: update user manual and added policy selection screenshots #208

Closed saudkhan116 closed 6 months ago

saudkhan116 commented 6 months ago

Why we create this PR?

What we want to achieve with this PR?

To be compliant with the Quality gates.

What is new?

Updated

gitguardian[bot] commented 6 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9104228](https://dashboard.gitguardian.com/incidents/9104228?occurrence=124065755) | Ignored | Generic High Entropy Secret | 1ce4d8134001873bb2e990ea4e3e2f6001e1268b | src/assets/MOCK/search.json | [View secret](https://github.com/eclipse-tractusx/digital-product-pass/commit/1ce4d8134001873bb2e990ea4e3e2f6001e1268b#diff-3307459c456ddb225885c968cc9db1a43fe32b1e54d951754d29b6d4a9c4c847L5) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

matbmoser commented 6 months ago

IP checks runned and not finding

matbmoser commented 6 months ago

The token added is not a secret!